From: Christoph Hellwig <hch@infradead.org>
To: Gargi Sharma <gs051095@gmail.com>
Cc: linux-kernel@vger.kernel.org, riel@surriel.com,
julia.lawall@lip6.fr, akpm@linux-foundation.org,
mingo@kernel.org, pasha.tatashin@oracle.com,
ktkhai@virtuozzo.com, oleg@redhat.com
Subject: Re: [PATCH v2 1/2] pid: Replace pid bitmap implementation with IDR API
Date: Sun, 1 Oct 2017 02:15:20 -0700 [thread overview]
Message-ID: <20171001091520.GA21161@infradead.org> (raw)
In-Reply-To: <e4bed733a4f8d7e8462a90a62f3b2fe15700c137.1506488388.git.gs051095@gmail.com>
> - task_active_pid_ns(current)->last_pid);
> + task_active_pid_ns(current)->idr.idr_next-1);
I think we want a well documented helper for this pattern instead
of poking into the internals.
Also is last - 1 always the correct answer? Even with idr_alloc_cyclic
we could wrap around, couldn't we?
next prev parent reply other threads:[~2017-10-01 9:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 5:06 [PATCH v2 0/2] Replace PID bitmap allocation with IDR API Gargi Sharma
2017-09-27 5:06 ` [PATCH v2 1/2] pid: Replace pid bitmap implementation " Gargi Sharma
2017-09-27 13:09 ` Rik van Riel
2017-09-27 14:06 ` Oleg Nesterov
2017-09-27 15:06 ` Gargi Sharma
2017-09-27 15:15 ` Oleg Nesterov
2017-09-27 15:05 ` Gargi Sharma
2017-09-27 15:05 ` Oleg Nesterov
2017-10-01 9:15 ` Christoph Hellwig [this message]
2017-10-01 10:35 ` Gargi Sharma
2017-10-02 13:14 ` Rik van Riel
2017-10-02 13:05 ` Rik van Riel
2017-09-27 5:06 ` [PATCH v2 2/2] pid: Remove pidhash Gargi Sharma
2017-09-27 15:45 ` Oleg Nesterov
2017-09-27 16:28 ` Oleg Nesterov
2017-09-30 15:41 ` Gargi Sharma
2017-10-02 15:03 ` Oleg Nesterov
2017-10-02 13:35 ` Rik van Riel
2017-10-02 13:45 ` Rik van Riel
2017-10-02 15:21 ` Oleg Nesterov
2017-10-02 15:22 ` Rik van Riel
2017-10-02 16:27 ` Gargi Sharma
2017-09-27 17:18 ` [PATCH v2 0/2] Replace PID bitmap allocation with IDR API Eric W. Biederman
[not found] ` <CAOCi2DESqWV2YPcRTe6NYjx6m6N19ewXbAyfLfeBa23kJiEO9Q@mail.gmail.com>
2017-09-28 19:46 ` Rik van Riel
2017-09-28 20:05 ` Gargi Sharma
2017-09-29 0:35 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171001091520.GA21161@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=gs051095@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.