Re: [PATCH] iio: dummy: events: Add missing break

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 29 Sep 2017 15:24:05 +0200
Lars-Peter Clausen <lars@metafoo.de> wrote:

> Add missing break in iio_simple_dummy_write_event_config() for the voltage
> threshold event enable attribute. Without this writing to the
> in_voltage0_thresh_rising_en always returns -EINVAL even though the change
> was correctly applied.
> 
> Fixes: 3e34e650db197 ("iio: dummy: Demonstrate the usage of new channel types")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Applied to the fixes-togreg branch of iio.git and marked for stable.
It's hardly a critical stable fix, but the risk is obviously very low
as well ;)

Thanks,

Jonathan
> ---
>  drivers/iio/dummy/iio_simple_dummy_events.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/dummy/iio_simple_dummy_events.c b/drivers/iio/dummy/iio_simple_dummy_events.c
> index ed63ffd849f8..7ec2a0bb0807 100644
> --- a/drivers/iio/dummy/iio_simple_dummy_events.c
> +++ b/drivers/iio/dummy/iio_simple_dummy_events.c
> @@ -72,6 +72,7 @@ int iio_simple_dummy_write_event_config(struct iio_dev *indio_dev,
>  				st->event_en = state;
>  			else
>  				return -EINVAL;
> +			break;
>  		default:
>  			return -EINVAL;
>  		}