From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbdJBJcw (ORCPT ); Mon, 2 Oct 2017 05:32:52 -0400 Received: from mga09.intel.com ([134.134.136.24]:44982 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdJBJcu (ORCPT ); Mon, 2 Oct 2017 05:32:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,468,1500966000"; d="scan'208";a="905805130" Date: Mon, 2 Oct 2017 12:28:25 +0300 From: Mika Westerberg To: Bhumika Goyal Cc: julia.lawall@lip6.fr, andreas.noever@gmail.com, michael.jamet@intel.com, yehezkel.bernat@intel.com, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] thunderbolt: make tb_domain_type const Message-ID: <20171002092825.GP4630@lahna.fi.intel.com> References: <1506789432-9967-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506789432-9967-1-git-send-email-bhumirks@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 30, 2017 at 10:07:12PM +0530, Bhumika Goyal wrote: > Make this const as it is only stored in the const field of a device > structure. Make the declaration in header const too. > > Structure found using Coccinelle and changes done by hand. > > Signed-off-by: Bhumika Goyal This looks good. However, I'm currently doing some shuffling in drivers/thunderbolt/tb.h to get Thunderbolt services supported which makes this patch not to apply cleanly anymore: https://lkml.org/lkml/2017/9/25/225 I wonder if you could rebase your patch on top of that? Also please Cc Greg as well.