From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: fix misleading data abort decoding
Date: Mon, 2 Oct 2017 13:02:23 +0100 [thread overview]
Message-ID: <20171002120223.GA11940@arm.com> (raw)
In-Reply-To: <1506944520-21998-1-git-send-email-mark.rutland@arm.com>
On Mon, Oct 02, 2017 at 12:42:00PM +0100, Mark Rutland wrote:
> Currently data_abort_decode() dumps the ISS field as a decimal value
> with a '0x' prefix, which is somewhat misleading.
>
> Fix it to print as hexadecimal, as was intended.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Julien Thierry <julien.thierry@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Fixes: 1f9b8936f36f4a8e ("arm64: Decode information from ESR upon mem faults")
> ---
> arch/arm64/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 89993c4b..a6d5281 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -97,7 +97,7 @@ static void data_abort_decode(unsigned int esr)
> (esr & ESR_ELx_SF) >> ESR_ELx_SF_SHIFT,
> (esr & ESR_ELx_AR) >> ESR_ELx_AR_SHIFT);
> } else {
> - pr_alert(" ISV = 0, ISS = 0x%08lu\n", esr & ESR_ELx_ISS_MASK);
> + pr_alert(" ISV = 0, ISS = 0x%08lx\n", esr & ESR_ELx_ISS_MASK);
> }
>
> pr_alert(" CM = %lu, WnR = %lu\n",
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-10-02 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 11:42 [PATCH] arm64: fix misleading data abort decoding Mark Rutland
2017-10-02 12:02 ` Will Deacon [this message]
2017-10-02 12:17 ` Julien Thierry
2017-10-02 12:54 ` Dave Martin
2017-10-02 14:06 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002120223.GA11940@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.