From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: shell: Add test for chain rename.
Date: Mon, 2 Oct 2017 14:35:42 +0200 [thread overview]
Message-ID: <20171002123542.GA8929@salvia> (raw)
In-Reply-To: <20171002110154.19721-1-rvarsha016@gmail.com>
On Mon, Oct 02, 2017 at 04:31:54PM +0530, Varsha Rao wrote:
> This patch adds test for chain rename use case.
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> tests/shell/testcases/chains/0013rename_1 | 9 +++++++++
> 1 file changed, 9 insertions(+)
> create mode 100755 tests/shell/testcases/chains/0013rename_1
>
> diff --git a/tests/shell/testcases/chains/0013rename_1 b/tests/shell/testcases/chains/0013rename_1
> new file mode 100755
> index 0000000..a69d855
> --- /dev/null
> +++ b/tests/shell/testcases/chains/0013rename_1
> @@ -0,0 +1,9 @@
> +#!/bin/bash
> +
> +set -e
> +
> +$NFT add table t
> +$NFT add chain t c1
> +# kernel should return EEXIST
Wait, I guess you mean here: "kernel should not return EEXIST as per
0d18779be13766b33c69cbc26df38383598da373", right? I can mangle this
line here before applying.
> +$NFT rename chain t c1 c2 2>/dev/null
> +echo "E: Renamed chain with non existing chain" >&2
BTW, could you also add a test to make sure we don't allow a rename
from 'c1' to 'c2' if chain 'c2' already exists.
next prev parent reply other threads:[~2017-10-02 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 11:01 [PATCH nft] tests: shell: Add test for chain rename Varsha Rao
2017-10-02 12:35 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-02 10:47 Varsha
2017-10-02 11:06 ` Varsha Rao
2017-10-02 12:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002123542.GA8929@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.