From: Kalle Valo <kvalo@codeaurora.org>
To: Kevin Cernekee <cernekee@chromium.org>
Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com,
brcm80211-dev-list.pdl@broadcom.com,
linux-wireless@vger.kernel.org, mnissler@chromium.org
Subject: Re: [V3,3/3] brcmfmac: Add check for short event packets
Date: Mon, 2 Oct 2017 12:46:59 +0000 (UTC) [thread overview]
Message-ID: <20171002124659.074B7607CE@smtp.codeaurora.org> (raw)
In-Reply-To: <20170917040824.22237-3-cernekee@chromium.org>
Kevin Cernekee <cernekee@chromium.org> wrote:
> The length of the data in the received skb is currently passed into
> brcmf_fweh_process_event() as packet_len, but this value is not checked.
> event_packet should be followed by DATALEN bytes of additional event
> data. Ensure that the received packet actually contains at least
> DATALEN bytes of additional data, to avoid copying uninitialized memory
> into event->data.
>
> Suggested-by: Mattias Nissler <mnissler@chromium.org>
> Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
I'll queue this for v4.14 and add:
Cc: stable@vger.kernel.org # v3.8
--
https://patchwork.kernel.org/patch/9954607/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-10-02 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 4:08 [PATCH V3 1/3] brcmfmac: Avoid possible out-of-bounds read Kevin Cernekee
2017-09-17 4:08 ` [PATCH V3 2/3] brcmfmac: Delete redundant length check Kevin Cernekee
2017-09-17 4:08 ` [PATCH V3 3/3] brcmfmac: Add check for short event packets Kevin Cernekee
2017-10-02 12:46 ` Kalle Valo [this message]
2017-10-02 13:51 ` [V3,3/3] " Kalle Valo
2017-10-02 14:07 ` [V3,1/3] brcmfmac: Avoid possible out-of-bounds read Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002124659.074B7607CE@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=cernekee@chromium.org \
--cc=franky.lin@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mnissler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.