From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
dtor@chromium.org
Subject: Re: [PATCH] HID: hid-multitouch: forward MSC_TIMESTAMP
Date: Mon, 2 Oct 2017 15:01:52 +0200 [thread overview]
Message-ID: <20171002130152.GI1063@mail.corp.redhat.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1710021434050.17517@jbgna.fhfr.qr>
On Oct 02 2017 or thereabouts, Jiri Kosina wrote:
> On Tue, 22 Aug 2017, Nicolas Boichat wrote:
>
> > Computes and forwards the device timestamp according to the
> > specification.
> >
> > Many devices use a 16-bit timestamp field, with a resolution
> > of 100us, therefore rolling around very frequently (every
> > 6.5 seconds). To make sure there is no ambiguity, the
> > timestamp reported to the input stack reset to 0 whenever
> > the time between 2 received events is greater than
> > MAX_TIMESTAMP_INTERVAL (1 second).
> >
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>
> > ---
> >
> > Inspired from Benjamin Tissoires's patch here:
> > https://patchwork.kernel.org/patch/1742181/, and changing the
> > logic to resynchronize the timestamps to use received time
> > instead of a potentially more fragile difference between
> > the 2 deltas.
>
> Benjamin, any objections on merging this one for 4.15? I like it.
>
No objections from my side.
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
next prev parent reply other threads:[~2017-10-02 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 1:10 [PATCH] HID: hid-multitouch: forward MSC_TIMESTAMP Nicolas Boichat
2017-10-02 12:34 ` Jiri Kosina
2017-10-02 13:01 ` Benjamin Tissoires [this message]
2017-10-05 9:18 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002130152.GI1063@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=drinkcat@chromium.org \
--cc=dtor@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.