From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
Johannes Thumshirn <jthumshirn@suse.de>,
Cathy Avery <cavery@redhat.com>,
Martin Steigerwald <martin@lichtvoll.de>,
linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Bart Van Assche <Bart.VanAssche@wdc.com>
Subject: Re: [PATCH V7 3/6] block: pass flags to blk_queue_enter()
Date: Mon, 2 Oct 2017 06:40:32 -0700 [thread overview]
Message-ID: <20171002134032.GC19119@infradead.org> (raw)
In-Reply-To: <20170930061214.10622-4-ming.lei@redhat.com>
On Sat, Sep 30, 2017 at 02:12:11PM +0800, Ming Lei wrote:
> We need to pass PREEMPT flags to blk_queue_enter()
> for allocating request with RQF_PREEMPT in the
> following patch.
I don't like having another name space for flags. It seems like
we should simply pass ops on, and then map the nowait allocations
to RQF_PREEMPT to REQ_PREEMPT as done in the series from Bart.
next prev parent reply other threads:[~2017-10-02 13:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 6:12 [PATCH V7 0/6] block/scsi: safe SCSI quiescing Ming Lei
2017-09-30 6:12 ` [PATCH V7 1/6] blk-mq: only run hw queues for blk-mq Ming Lei
2017-10-02 13:31 ` Christoph Hellwig
2017-09-30 6:12 ` [PATCH V7 2/6] block: tracking request allocation with q_usage_counter Ming Lei
2017-10-02 13:32 ` Christoph Hellwig
2017-10-02 16:01 ` Bart Van Assche
2017-10-02 16:01 ` Bart Van Assche
2017-09-30 6:12 ` [PATCH V7 3/6] block: pass flags to blk_queue_enter() Ming Lei
2017-10-02 13:40 ` Christoph Hellwig [this message]
2017-10-03 7:21 ` Ming Lei
2017-09-30 6:12 ` [PATCH V7 4/6] block: prepare for passing RQF_PREEMPT to request allocation Ming Lei
2017-10-02 13:45 ` Christoph Hellwig
2017-09-30 6:12 ` [PATCH V7 5/6] block: support PREEMPT_ONLY Ming Lei
2017-10-02 13:50 ` Christoph Hellwig
2017-10-03 8:22 ` Ming Lei
2017-10-02 16:27 ` Bart Van Assche
2017-10-02 16:27 ` Bart Van Assche
2017-10-03 8:13 ` Ming Lei
2017-09-30 6:12 ` [PATCH V7 6/6] SCSI: set block queue at preempt only when SCSI device is put into quiesce Ming Lei
2017-10-02 13:52 ` Christoph Hellwig
2017-10-03 8:17 ` Ming Lei
2017-09-30 9:47 ` [PATCH V7 0/6] block/scsi: safe SCSI quiescing Martin Steigerwald
2017-09-30 9:47 ` Martin Steigerwald
2017-09-30 9:51 ` Ming Lei
2017-09-30 9:51 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002134032.GC19119@infradead.org \
--to=hch@infradead.org \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=cavery@redhat.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=martin@lichtvoll.de \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.