Re: [PATCH] libmount: if ENOMEDIUM and tray is open, close tray and retry

["Michal Suchánek" <msuchanek@suse.de>]

On Mon, 2 Oct 2017 15:06:33 +0200
Stanislav Brabec <sbrabec@suse.cz> wrote:

> Michal Suchánek wrote:
> > it is completely reasonable to return ENOMEDIUM from kernel when the
> > tray is open and let userspace decide if it wants to attempt to
> > close the tray and how long it wants to wait for the tray to close
> > (it may be blocked/broken).
> >   
> But then, what is the purpose of /proc/sys/dev/cdrom/autoclose?

It can be used as a hint in mount if closing the tray is desired or
not.

I guess this used to work with IDE drivers not using SCSI emulation.

With SCSI the close tray command is executed like any other with
default timeout and obviously does time out in most cases. 

But how long should the kernel wait? Is 1 minute ok? Should it wait 5
minutes in case the user did not align the medium properly and needs to
realign it? Who should set this timeout, where?

Thanks

Michal