From: Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH 4/6] amdgpu/dc: convert dc_stream_state to kref.
Date: Tue, 3 Oct 2017 12:39:00 +1000 [thread overview]
Message-ID: <20171003023902.5036-5-airlied@gmail.com> (raw)
In-Reply-To: <20171003023902.5036-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Dave Airlie <airlied@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 22 +++++++++++-----------
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
index a9919641..23df7bc 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
@@ -118,20 +118,21 @@ static void destruct(struct dc_stream_state *stream)
void dc_stream_retain(struct dc_stream_state *stream)
{
- ASSERT(atomic_read(&stream->ref_count) > 0);
- atomic_inc(&stream->ref_count);
+ kref_get(&stream->refcount);
+}
+
+static void dc_stream_free(struct kref *kref)
+{
+ struct dc_stream_state *stream = container_of(kref, struct dc_stream_state, refcount);
+
+ destruct(stream);
+ kfree(stream);
}
void dc_stream_release(struct dc_stream_state *stream)
{
if (stream != NULL) {
- ASSERT(atomic_read(&stream->ref_count) > 0);
- atomic_dec(&stream->ref_count);
-
- if (atomic_read(&stream->ref_count) == 0) {
- destruct(stream);
- kfree(stream);
- }
+ kref_put(&stream->refcount, dc_stream_free);
}
}
@@ -149,10 +150,9 @@ struct dc_stream_state *dc_create_stream_for_sink(
construct(stream, sink);
- atomic_inc(&stream->ref_count);
+ kref_init(&stream->refcount);
return stream;
-
}
struct dc_stream_status *dc_stream_get_status(
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index c4d89d2..abba134 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -562,7 +562,7 @@ struct dc_stream_state {
struct dc_stream_status status;
/* from stream struct */
- atomic_t ref_count;
+ struct kref refcount;
};
struct dc_stream_update {
--
2.9.5
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-10-03 2:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 2:38 convert dc to using krefs for object reference counts Dave Airlie
[not found] ` <20171003023902.5036-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-03 2:38 ` [PATCH 1/6] amdgpu/dc: convert dc_transfer to use a kref Dave Airlie
[not found] ` <20171003023902.5036-2-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-03 7:48 ` Christian König
2017-10-03 2:38 ` [PATCH 2/6] amdgpu/dc: convert dc_gamma to kref reference counting Dave Airlie
2017-10-03 2:38 ` [PATCH 3/6] amdgpu/dc: use kref for dc_plane_state Dave Airlie
2017-10-03 2:39 ` Dave Airlie [this message]
2017-10-03 2:39 ` [PATCH 5/6] amdgpu/dc: convert dc_sink to kref Dave Airlie
2017-10-03 2:39 ` [PATCH 6/6] amdgpu/dc: use kref for dc_state Dave Airlie
2017-10-03 7:50 ` convert dc to using krefs for object reference counts Christian König
2017-10-03 21:14 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003023902.5036-5-airlied@gmail.com \
--to=airlied-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.