From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH V5 6/8] block: introduce .last_merge and .hash to blk_mq_ctx Date: Tue, 3 Oct 2017 02:19:22 -0700 Message-ID: <20171003091922.GD2771@infradead.org> References: <20170930112655.31451-1-ming.lei@redhat.com> <20170930112655.31451-7-ming.lei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170930112655.31451-7-ming.lei@redhat.com> Sender: linux-block-owner@vger.kernel.org To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Mike Snitzer , dm-devel@redhat.com, Bart Van Assche , Laurence Oberman , Paolo Valente , Oleksandr Natalenko , Tom Nguyen , linux-kernel@vger.kernel.org, Omar Sandoval List-Id: dm-devel.ids > +enum elv_merge elv_merge_ctx(struct request_queue *q, struct request **req, > + struct bio *bio, struct blk_mq_ctx *ctx) > +{ > + WARN_ON_ONCE(!q->mq_ops); > + return __elv_merge(q, req, bio, ctx->hash, ctx->last_merge); > +} This function only has a single caller, just open code it.