From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Date: Tue, 03 Oct 2017 12:41:45 +0000 Subject: Re: [PATCH] net: dsa: lan9303: make functions lan9303_mdio_phy_{read|write} static Message-Id: <20171003124145.GE13548@lunn.ch> List-Id: References: <20171003103918.26934-1-colin.king@canonical.com> In-Reply-To: <20171003103918.26934-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 11:39:18AM +0100, Colin King wrote: > From: Colin Ian King > > The functions lan9303_mdio_phy_write and lan9303_mdio_phy_read are local > to the source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'lan9303_mdio_phy_write' was not declared. Should it be static? > symbol 'lan9303_mdio_phy_read' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754319AbdJCMmF (ORCPT ); Tue, 3 Oct 2017 08:42:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37106 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdJCMls (ORCPT ); Tue, 3 Oct 2017 08:41:48 -0400 Date: Tue, 3 Oct 2017 14:41:45 +0200 From: Andrew Lunn To: Colin King Cc: Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: lan9303: make functions lan9303_mdio_phy_{read|write} static Message-ID: <20171003124145.GE13548@lunn.ch> References: <20171003103918.26934-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171003103918.26934-1-colin.king@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 11:39:18AM +0100, Colin King wrote: > From: Colin Ian King > > The functions lan9303_mdio_phy_write and lan9303_mdio_phy_read are local > to the source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'lan9303_mdio_phy_write' was not declared. Should it be static? > symbol 'lan9303_mdio_phy_read' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Reviewed-by: Andrew Lunn Andrew