From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IL5okzt2H7dQ4aWWrCY8FlzqAqMfen+mIGwM4lATuF0=; b=yZ1DvCXQvxqXKzR2f9ssgtKFTXp+ZH71zs6kGWCIIimD7KPQH8RfJSt5O5h2EVf6Dw k1y5QBJPndKd3OABA654zPcfXnM7yciCd4uVZgQahUHotFgyL6TYnWv+mEoU0S5o/FqY sBpnY2mwqzSg9C4exNn+qHAQuZX6eXOsEzk8Q7suvDUW5oUQdN4vjXyeNzxM8HBdt6Ke oQXJ6SYZJHlOwNdFO1gT3Vb2esbAVIsdKfZK63avNeDtQRScA9T2NogmyzLdPHCvU1yg HYE0xKuk/rYjcZr3GEx0DrX1QVg/xKoj8t7rCUcnm1QkkoEQML77g2PzYhDivhGWJ8Zc BVnQ== Date: Tue, 3 Oct 2017 13:43:11 -0700 From: Stephen Hemminger Message-ID: <20171003134311.34681644@xeon-e3> In-Reply-To: <1472267428-810527-1-git-send-email-green@linuxhacker.ru> References: <1472267428-810527-1-git-send-email-green@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH] bridge: Fix format string for %ul List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Oleg Drokin Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, "David S. Miller" , linux-kernel@vger.kernel.org On Fri, 26 Aug 2016 23:10:28 -0400 Oleg Drokin wrote: > %ul would print an unsigned value and a letter l, > likely it was %lu that was meant to print the long int, > but in reality the values printed there are just regular signed > ints, so just dropping the l altogether. > > Signed-off-by: Oleg Drokin > --- > net/bridge/br_stp_bpdu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c > index 5881fbc..15c4a9c 100644 > --- a/net/bridge/br_stp_bpdu.c > +++ b/net/bridge/br_stp_bpdu.c > @@ -230,7 +230,7 @@ void br_stp_rcv(const struct stp_proto *proto, struct sk_buff *skb, > if (net_ratelimit()) > br_notice(p->br, > "port %u config from %pM" > - " (message_age %ul > max_age %ul)\n", > + " (message_age %u > max_age %u)\n", > p->port_no, > eth_hdr(skb)->h_source, > bpdu.message_age, bpdu.max_age); Could you make the format string a single line plwase. And add Fixes tag. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbdJCUnU (ORCPT ); Tue, 3 Oct 2017 16:43:20 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:53829 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbdJCUnS (ORCPT ); Tue, 3 Oct 2017 16:43:18 -0400 X-Google-Smtp-Source: AOwi7QDzm6bUa7pBmbjfvVsg8aAXn2gpCP37kJ78jFo3mduhJcO1r4zQf7sNTwTVaT2J4jPVZwwfgg== Date: Tue, 3 Oct 2017 13:43:11 -0700 From: Stephen Hemminger To: Oleg Drokin Cc: "David S. Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bridge: Fix format string for %ul Message-ID: <20171003134311.34681644@xeon-e3> In-Reply-To: <1472267428-810527-1-git-send-email-green@linuxhacker.ru> References: <1472267428-810527-1-git-send-email-green@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Aug 2016 23:10:28 -0400 Oleg Drokin wrote: > %ul would print an unsigned value and a letter l, > likely it was %lu that was meant to print the long int, > but in reality the values printed there are just regular signed > ints, so just dropping the l altogether. > > Signed-off-by: Oleg Drokin > --- > net/bridge/br_stp_bpdu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c > index 5881fbc..15c4a9c 100644 > --- a/net/bridge/br_stp_bpdu.c > +++ b/net/bridge/br_stp_bpdu.c > @@ -230,7 +230,7 @@ void br_stp_rcv(const struct stp_proto *proto, struct sk_buff *skb, > if (net_ratelimit()) > br_notice(p->br, > "port %u config from %pM" > - " (message_age %ul > max_age %ul)\n", > + " (message_age %u > max_age %u)\n", > p->port_no, > eth_hdr(skb)->h_source, > bpdu.message_age, bpdu.max_age); Could you make the format string a single line plwase. And add Fixes tag.