All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Julien Grall <julien.grall@linaro.org>, marc.zyngier@arm.com
Cc: robh+dt@kernel.org, jason@lakedaemon.net, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] DT/arm,gic-v3: Update the ITS size in the examples
Date: Tue, 3 Oct 2017 15:53:33 +0100	[thread overview]
Message-ID: <20171003145333.GE4931@leverpostej> (raw)
In-Reply-To: <20171003142027.23243-1-julien.grall@linaro.org>

On Tue, Oct 03, 2017 at 03:20:27PM +0100, Julien Grall wrote:
> Currently, the examples are using 2MB for the ITS size. Per the
> specification (section 8.18 in ARM IHI 0069D), the ITS address map is
> 128KB.
> 
> Update the examples to match the specification.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>

This looks sane to me, per my reading of that section of the spec.

Marc, was there some reason we used such a large size? Or was the extra
zero unintentional?

Thanks,
Mark.

> ---
>  .../devicetree/bindings/interrupt-controller/arm,gic-v3.txt         | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> index 4c29cdab0ea5..5eb108e180fa 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> @@ -99,7 +99,7 @@ Examples:
>  			compatible = "arm,gic-v3-its";
>  			msi-controller;
>  			#msi-cells = <1>;
> -			reg = <0x0 0x2c200000 0 0x200000>;
> +			reg = <0x0 0x2c200000 0 0x20000>;
>  		};
>  	};
>  
> @@ -124,14 +124,14 @@ Examples:
>  			compatible = "arm,gic-v3-its";
>  			msi-controller;
>  			#msi-cells = <1>;
> -			reg = <0x0 0x2c200000 0 0x200000>;
> +			reg = <0x0 0x2c200000 0 0x20000>;
>  		};
>  
>  		gic-its@2c400000 {
>  			compatible = "arm,gic-v3-its";
>  			msi-controller;
>  			#msi-cells = <1>;
> -			reg = <0x0 0x2c400000 0 0x200000>;
> +			reg = <0x0 0x2c400000 0 0x20000>;
>  		};
>  
>  		ppi-partitions {
> -- 
> 2.11.0
> 

  reply	other threads:[~2017-10-03 14:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 14:20 [PATCH] DT/arm,gic-v3: Update the ITS size in the examples Julien Grall
2017-10-03 14:20 ` Julien Grall
2017-10-03 14:53 ` Mark Rutland [this message]
2017-10-03 15:03   ` Marc Zyngier
2017-10-03 15:03     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171003145333.GE4931@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=julien.grall@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.