From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH 2/2] block: fix peeking requests during PM
Date: Tue, 3 Oct 2017 17:19:57 +0200 [thread overview]
Message-ID: <20171003151957.GA5995@lst.de> (raw)
In-Reply-To: <1507043621.2702.4.camel@wdc.com>
On Tue, Oct 03, 2017 at 03:13:43PM +0000, Bart Van Assche wrote:
> > + switch (rq->q->rpm_status) {
> > + case RPM_SUSPENDED:
> > + return false;
> > + case RPM_ACTIVE:
> > + return rq->rq_flags & RQF_PM;
> > + default:
> > + return true;
> > + }
> > }
>
> Hello Christoph,
>
> The old code does not process non-PM requests in the RPM_SUSPENDING mode nor
> in the RPM_RESUMING code. I think the new code processes all requests in
> these two modes. Was that behavior change intended?
Yeah, looks like this version has the RPM_ACTIVE and default cases
switched. Back to the drawing board.
next prev parent reply other threads:[~2017-10-03 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 8:46 RQF_PM fix/cleanup Christoph Hellwig
2017-10-03 8:47 ` [PATCH 1/2] block: move __elv_next_request to blk-core.c Christoph Hellwig
2017-10-03 8:47 ` [PATCH 2/2] block: fix peeking requests during PM Christoph Hellwig
2017-10-03 15:13 ` Bart Van Assche
2017-10-03 15:19 ` hch [this message]
2017-10-03 14:43 ` RQF_PM fix/cleanup Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003151957.GA5995@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.