All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Georgiana Chelu <georgiana.chelu93@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v3 6/7] Staging: media: atomisp: Merge quoted string split across lines
Date: Tue, 3 Oct 2017 18:15:19 +0200	[thread overview]
Message-ID: <20171003161519.GC7303@kroah.com> (raw)
In-Reply-To: <89918bf8d752305d253b9fda889fdbfe04456900.1506891671.git.georgiana.chelu93@gmail.com>

On Mon, Oct 02, 2017 at 12:34:41AM +0300, Georgiana Chelu wrote:
> Prefer merging quoted strings on one line than splitting them,
> even if the line exceeds 80 characters. It is easier to
> read and grep for strings that are not split. Also, split
> one line with over 80 characters.

It's nice to wrap changelog lines, but please do so at 72 columns.

Mauro, are you going to be taking these types of changes for this
driver, or do you want me to?

thanks,

greg k-h


  reply	other threads:[~2017-10-03 16:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-01 21:34 [PATCH v3 0/7] Fix checkpatch issues Georgiana Chelu
2017-10-01 21:34 ` [PATCH v3 1/7] Staging: media: atomisp: Remove useless 'out of memory' messages Georgiana Chelu
2017-10-01 21:34 ` [PATCH v3 2/7] Staging: media: atomisp: Remove unlikely from NULL pointer check Georgiana Chelu
2017-10-01 21:34 ` [PATCH v3 3/7] Staging: media: atomisp: Adjust checks for null pointers Georgiana Chelu
2017-10-01 21:34 ` [PATCH v3 4/7] Staging: media: atomisp: Remove return statement from void function Georgiana Chelu
2017-10-01 21:34 ` [PATCH v3 5/7] Staging: media: atomisp: Add spaces around bitwise OR Georgiana Chelu
2017-10-01 21:34 ` [PATCH v3 6/7] Staging: media: atomisp: Merge quoted string split across lines Georgiana Chelu
2017-10-03 16:15   ` Greg Kroah-Hartman [this message]
2017-10-01 21:34 ` [PATCH v3 7/7] Staging: media: atomisp: Align code with open parenthesis Georgiana Chelu
2017-10-03 16:09 ` [PATCH v3 0/7] Fix checkpatch issues Greg Kroah-Hartman
2017-10-07 21:31   ` Georgiana Chelu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171003161519.GC7303@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=georgiana.chelu93@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.