From: Mark Rutland <mark.rutland@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] bus: CCN/CCI: Fix use of smp_processor_id()
Date: Tue, 3 Oct 2017 18:18:47 +0100 [thread overview]
Message-ID: <20171003171847.GG4931@leverpostej> (raw)
In-Reply-To: <20171003171413.18592-1-marc.zyngier@arm.com>
On Tue, Oct 03, 2017 at 06:14:11PM +0100, Marc Zyngier wrote:
> I've just noticed that both the CCI and CCN drivers have a small
> buglet in that they call smp_processor_id() from preemptible context,
> which is frown upon (having just booted a 4.13 kernel with
> DEBUG_PREEMPT on my Seattle, I was surprised to be greeted with a nice
> backtrace...).
>
> I've tested the CCN patch on the same Seatle box, but I've only
> compile-tested the equivalent CCI patch (which is obviously correct --
> famous last words...).
>
> Thanks,
>
> M.
>
> * From v1: Keep the current CPU refcount until we have registered the
> CPU notifiers, making sure we don't race against a surprise hotplug
> off.
>
> Marc Zyngier (2):
> bus: arm-ccn: Fix use of smp_processor_id() in preemptible context
> bus: arm-cci: Fix use of smp_processor_id() in preemptible context
For both:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
prev parent reply other threads:[~2017-10-03 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 17:14 [PATCH v2 0/2] bus: CCN/CCI: Fix use of smp_processor_id() Marc Zyngier
2017-10-03 17:14 ` [PATCH v2 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context Marc Zyngier
2017-10-04 11:26 ` Pawel Moll
2017-10-04 12:32 ` Marc Zyngier
2017-10-04 12:33 ` Pawel Moll
2017-10-03 17:14 ` [PATCH v2 2/2] bus: arm-cci: " Marc Zyngier
2017-10-03 17:18 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003171847.GG4931@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=pawel.moll@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.