All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] syscalls, lib: Use SAFE_{BIND, LISTEN, SOCKET} macros
Date: Tue, 3 Oct 2017 21:05:41 +0200	[thread overview]
Message-ID: <20171003190540.GA7210@rei> (raw)
In-Reply-To: <778521072.25826642.1507054113445.JavaMail.zimbra@redhat.com>

Hi!
> > > Really nice solution :-).
> > > This script is really worth of adding into LTP (even it requires to check
> > > formatting).
> > 
> > I will strip the old library parts, then we can add it, maybe we can
> > even use it as a commit hook or something to automatically check if
> > we could have used a SAFE_MACRO() instead of custom error handling...
> > 
> 
> As I was looking at changes, I came across:
>   tst_brkm(TFAIL | TERRNO, ...);
> 
> I guess most of these tst_brk TFAILs should be TBROKs, but that would be
> likely difficult to script.

Yes, we would have to review which of these are real TFAILs manually,
which could be done, but would be quite time consuming. So I stuck with
changes I can formally prove are equal.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2017-10-03 19:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 23:10 [LTP] [PATCH 1/1] syscalls, lib: Use SAFE_{BIND, LISTEN, SOCKET} macros Petr Vorel
2017-09-29 23:15 ` Petr Vorel
2017-10-02 11:00 ` Richard Palethorpe
2017-10-02 12:29   ` Petr Vorel
2017-10-02 14:51     ` Richard Palethorpe
2017-10-02 15:04       ` Petr Vorel
2017-10-02 15:21         ` Cyril Hrubis
2017-10-02 15:36           ` Petr Vorel
2017-10-03 11:43             ` Cyril Hrubis
2017-10-03 12:31               ` Petr Vorel
2017-10-03 12:56                 ` Cyril Hrubis
2017-10-03 13:21                   ` Petr Vorel
2017-10-03 18:08                   ` Jan Stancek
2017-10-03 19:05                     ` Cyril Hrubis [this message]
2017-10-03 14:28                 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171003190540.GA7210@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.