From: Andrew Lunn <andrew@lunn.ch>
To: Troy Kisky <troy.kisky@boundarydevices.com>
Cc: shawn.guo@linaro.org, fugang.duan@nxp.com,
netdev@vger.kernel.org, davem@davemloft.net,
fabio.estevam@nxp.com, lznuaa@gmail.com
Subject: Re: [PATCH net v1 1/2] ARM: dts: imx: let's name the ptp interrupt for the fec ethernet driver
Date: Tue, 3 Oct 2017 22:53:59 +0200 [thread overview]
Message-ID: <20171003205359.GH30045@lunn.ch> (raw)
In-Reply-To: <b07b44ca-3804-bd7d-900c-556443a02ac8@boundarydevices.com>
On Tue, Oct 03, 2017 at 01:41:34PM -0700, Troy Kisky wrote:
> On 10/2/2017 5:51 PM, Andrew Lunn wrote:
> > On Mon, Oct 02, 2017 at 05:04:41PM -0700, Troy Kisky wrote:
> >> imx7s/imx7d has the ptp interrupt newly added as well.
> >> This will allow the ptp interrupt to have its own interrupt routine.
> >>
> >> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> >> ---
> >> arch/arm/boot/dts/imx6qdl.dtsi | 1 +
> >> arch/arm/boot/dts/imx6sx.dtsi | 2 ++
> >> arch/arm/boot/dts/imx6ul.dtsi | 2 ++
> >> arch/arm/boot/dts/imx7d.dtsi | 4 +++-
> >> arch/arm/boot/dts/imx7s.dtsi | 4 +++-
> >> 5 files changed, 11 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> >> index 8884b4a3cafb..d848d2bfe8e2 100644
> >> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> >> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> >> @@ -1017,6 +1017,7 @@
> >> fec: ethernet@02188000 {
> >> compatible = "fsl,imx6q-fec";
> >> reg = <0x02188000 0x4000>;
> >> + interrupt-names = "","ptp";
> >
> > Hi Troy
> >
> > The "" looks a bit odd. Can you use a name here?
> >
> > Andrew
> >
>
> Sure. Can I use "q0","q1","q2", and look them up by name in fec_main
> as well ?
Hi Troy
Is there no better name? How does the datasheet name them?
> Should I worrying about compatiblity with old dtbs ?
Yes. You cannot break old dtb blobs. So i would suggest keep looking
up the old interrupts by number. But this new interrupt you can use
the name.
Andrew
prev parent reply other threads:[~2017-10-03 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 0:04 [PATCH net v1 1/2] ARM: dts: imx: let's name the ptp interrupt for the fec ethernet driver Troy Kisky
2017-10-03 0:04 ` [PATCH net v1 2/2] net: fec: Let fec_ptp have its own interrupt routine Troy Kisky
2017-10-09 2:55 ` Andy Duan
2017-10-03 0:51 ` [PATCH net v1 1/2] ARM: dts: imx: let's name the ptp interrupt for the fec ethernet driver Andrew Lunn
2017-10-03 20:41 ` Troy Kisky
2017-10-03 20:53 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003205359.GH30045@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fabio.estevam@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.