All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, jcody@redhat.com,
	stefanha@redhat.com, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0/5] block: Avoid copy-on-read assertions
Date: Tue,  3 Oct 2017 20:43:42 -0500	[thread overview]
Message-ID: <20171004014347.25099-1-eblake@redhat.com> (raw)

During my quest to switch block status to be byte-based, John
forced me to evaluate whether we have a situation during
copy-on-read where we could exceed BDRV_REQUEST_MAX_BYTES [1].
Sure enough, we have a number of pre-existing bugs in the
copy-on-read code.  Fix those, along with adding a test.

Available as a tag at:
git fetch git://repo.or.cz/qemu/ericb.git nbd-byte-status-v4

Since v1 (available at [2]):
- tweak patch 3 (now 4) to avoid uninit variable [Kevin, patchew]
- tweak patch 4 (now 5) to add 0-length test [Kevin]
- tweak patch 4 (now 5) to skip if TEST_DIR contains spaces [Jeff]
- new patch 2 to make testing 0-length read easier

[1] https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg07286.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg08200.html

001/5:[----] [--] 'qemu-io: Add -C for opening with copy-on-read'
002/5:[down] 'block: Uniform handling of 0-length bdrv_get_block_status()'
003/5:[----] [--] 'block: Add blkdebug hook for copy-on-read'
004/5:[0001] [FC] 'block: Perform copy-on-read in loop'
005/5:[0025] [FC] 'iotests: Add test 197 for covering copy-on-read'

Eric Blake (5):
  qemu-io: Add -C for opening with copy-on-read
  block: Uniform handling of 0-length bdrv_get_block_status()
  block: Add blkdebug hook for copy-on-read
  block: Perform copy-on-read in loop
  iotests: Add test 197 for covering copy-on-read

 qapi/block-core.json             |   5 +-
 block/io.c                       | 123 ++++++++++++++++++++++++++-------------
 qemu-io.c                        |  15 ++++-
 tests/qemu-iotests/common.filter |   1 +
 tests/qemu-iotests/197           | 102 ++++++++++++++++++++++++++++++++
 tests/qemu-iotests/197.out       |  26 +++++++++
 tests/qemu-iotests/group         |   1 +
 7 files changed, 230 insertions(+), 43 deletions(-)
 create mode 100755 tests/qemu-iotests/197
 create mode 100644 tests/qemu-iotests/197.out

-- 
2.13.6

             reply	other threads:[~2017-10-04  1:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  1:43 Eric Blake [this message]
2017-10-04  1:43 ` [Qemu-devel] [PATCH v2 1/5] qemu-io: Add -C for opening with copy-on-read Eric Blake
2017-10-04  1:43 ` [Qemu-devel] [PATCH v2 2/5] block: Uniform handling of 0-length bdrv_get_block_status() Eric Blake
2017-10-05 14:35   ` Stefan Hajnoczi
2017-10-05 14:41     ` Eric Blake
2017-10-04  1:43 ` [Qemu-devel] [PATCH v2 3/5] block: Add blkdebug hook for copy-on-read Eric Blake
2017-10-04  1:43 ` [Qemu-devel] [PATCH v2 4/5] block: Perform copy-on-read in loop Eric Blake
2017-10-05 14:55   ` Kevin Wolf
2017-10-05 15:36   ` Stefan Hajnoczi
2017-10-04  1:43 ` [Qemu-devel] [PATCH v2 5/5] iotests: Add test 197 for covering copy-on-read Eric Blake
2017-10-05 14:41   ` Stefan Hajnoczi
2017-10-05 14:44     ` Eric Blake
2017-10-05 14:47       ` Eric Blake
2017-10-04  2:16 ` [Qemu-devel] [PATCH v2 0/5] block: Avoid copy-on-read assertions no-reply
2017-10-04  2:22   ` Eric Blake
2017-10-04  5:39     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004014347.25099-1-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.