All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC PATCH] i40e: Build for 64-bit targets only
Date: Wed, 4 Oct 2017 02:52:08 +0100	[thread overview]
Message-ID: <20171004015208.GA2971@decadent.org.uk> (raw)

i40e now uses cmpxchg64(), which only works on a 64-bit (or non-SMP)
system.  (It is currently defined for many 32-bit SMP configurations,
but not correctly!)  It seems reasonable to expect that 40G hardware
is not used on 32-bit systems.

Fixes: 841c950d67c6 ("i40e/i40evf: use cmpxchg64 when updating private ...")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
I specifically found a build failure on 32-bit parisc:

https://buildd.debian.org/status/fetch.php?pkg=linux&arch=hppa&ver=4.14%7Erc3-1%7Eexp1&stamp=1507045758&raw=0

Ben.

 drivers/net/ethernet/intel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
index 1feb54b6d92e..dd17bdf5561e 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig
@@ -215,6 +215,7 @@ config I40E
 	tristate "Intel(R) Ethernet Controller XL710 Family support"
 	imply PTP_1588_CLOCK
 	depends on PCI
+	depends on 64BIT
 	---help---
 	  This driver supports Intel(R) Ethernet Controller XL710 Family of
 	  devices.  For more information on how to identify your adapter, go
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171004/a7d4ff8b/attachment-0001.asc>

             reply	other threads:[~2017-10-04  1:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  1:52 Ben Hutchings [this message]
2017-10-04  2:24 ` [Intel-wired-lan] [RFC PATCH] i40e: Build for 64-bit targets only Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004015208.GA2971@decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.