From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751369AbdJDHYf (ORCPT ); Wed, 4 Oct 2017 03:24:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53092 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbdJDHYf (ORCPT ); Wed, 4 Oct 2017 03:24:35 -0400 Date: Wed, 4 Oct 2017 09:24:43 +0200 From: Greg KH To: Kai-Heng Feng Cc: mcgrof@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: add firmware to new device's devres list for second time cache Message-ID: <20171004072443.GA12006@kroah.com> References: <20170822075246.16315-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170822075246.16315-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. > > When a device loses its power or a USB device gets plugged to another > port under suspend, request_firmware() can still find cached firmware, > but firmware name no longer associates with the new device's devres. > So next time the system suspend, those firmware won't be cached. > > Hence, we should add the firmware name to the devres when the firmware > is found in cache, to make the firmware cacheable next time. > > Signed-off-by: Kai-Heng Feng > --- > drivers/base/firmware_class.c | 4 ++++ > 1 file changed, 4 insertions(+) Luis???