From: Stephen Hemminger <stephen@networkplumber.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Stefan Hajnoczi' <stefanha@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jorgen Hansen <jhansen@vmware.com>,
Dexuan Cui <decui@microsoft.com>
Subject: Re: [PATCH iproute2 1/3] ss: allow AF_FAMILY constants >32
Date: Wed, 4 Oct 2017 08:14:50 -0700 [thread overview]
Message-ID: <20171004081450.20973fe8@xeon-e3> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD0089AB4@AcuExch.aculab.com>
On Wed, 4 Oct 2017 15:03:09 +0000
David Laight <David.Laight@ACULAB.COM> wrote:
> From: Stefan Hajnoczi
> > Sent: 04 October 2017 16:01
> ...
> > > > --- a/misc/ss.c
> > > > +++ b/misc/ss.c
> > > > @@ -170,55 +170,57 @@ enum {
> > > > struct filter {
> > > > int dbs;
> > > > int states;
> > > > - int families;
> > > > + __u64 families;
> > >
> > > Since this isn't a value that is coming from kernel. It should be uint64_t
> > > rather than __u64.
> >
> > Okay, will fix in v2.
>
> But that looks like a kernel structure, not one exposed to userspace.
> So surely __u64 is correct.
>
> David
>
families is a bit field which is built from data, not from kernel.
next prev parent reply other threads:[~2017-10-04 15:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 17:57 [PATCH iproute2 0/3] ss: add AF_VSOCK support Stefan Hajnoczi
2017-10-03 17:57 ` [PATCH iproute2 1/3] ss: allow AF_FAMILY constants >32 Stefan Hajnoczi
2017-10-03 18:26 ` Stephen Hemminger
2017-10-04 15:01 ` Stefan Hajnoczi
2017-10-04 15:03 ` David Laight
2017-10-04 15:14 ` Stephen Hemminger [this message]
2017-10-03 17:57 ` [PATCH iproute2 2/3] include: add <linux/vm_sockets_diag.h> Stefan Hajnoczi
2017-10-03 18:24 ` Stephen Hemminger
2017-10-04 15:03 ` Stefan Hajnoczi
2017-10-03 17:57 ` [PATCH iproute2 3/3] ss: add AF_VSOCK support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004081450.20973fe8@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=David.Laight@ACULAB.COM \
--cc=decui@microsoft.com \
--cc=jhansen@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.