All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v2 1/7] nvme core: allow controller RESETTING to RECONNECTING transition
Date: Wed, 4 Oct 2017 01:28:13 -0700	[thread overview]
Message-ID: <20171004082813.GA23467@infradead.org> (raw)
In-Reply-To: <20170927045046.22238-2-jsmart2021@gmail.com>

On Tue, Sep 26, 2017@09:50:40PM -0700, James Smart wrote:
> Allow controller state transition : RESETTING to RECONNECTING
> 
> Transport will typically transition from LIVE->RESETTING when
> initially performing a reset or recovering from an error. Adding
> this transition allows a transport to transition to RECONNECTING
> when it checks/waits for connectivity then creates new transport
> connections and reinits the controller.

Looks fine for now, although we really need to move to a common
state machine..

Reviewed-by: Christoph Hellwig <hch at lst.de>

> 
> -- james
> 
> Signed-off-by: James Smart <james.smart at broadcom.com>
> ---
>  drivers/nvme/host/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index bb2aad078637..179ca6f79da3 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -205,6 +205,7 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
>  	case NVME_CTRL_RECONNECTING:
>  		switch (old_state) {
>  		case NVME_CTRL_LIVE:
> +		case NVME_CTRL_RESETTING:
>  			changed = true;
>  			/* FALLTHRU */
>  		default:
> -- 
> 2.13.1
> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
---end quoted text---

  reply	other threads:[~2017-10-04  8:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  4:50 [PATCH v2 0/7] nvme_fc: add dev_loss_tmo support James Smart
2017-09-27  4:50 ` [PATCH v2 1/7] nvme core: allow controller RESETTING to RECONNECTING transition James Smart
2017-10-04  8:28   ` Christoph Hellwig [this message]
2017-10-11 10:02     ` Sagi Grimberg
2017-09-27  4:50 ` [PATCH v2 2/7] nvme_fc: change ctlr state assignments during reset/reconnect James Smart
2017-10-05  7:57   ` Christoph Hellwig
2017-10-07 15:53     ` James Smart
2017-10-11 10:07       ` Sagi Grimberg
2017-10-11 14:29         ` James Smart
2017-09-27  4:50 ` [PATCH v2 3/7] nvme_fc: add a dev_loss_tmo field to the remoteport James Smart
2017-10-11 10:11   ` Sagi Grimberg
2017-10-11 14:35     ` James Smart
2017-09-27  4:50 ` [PATCH v2 4/7] nvme_fc: add dev_loss_tmo to controller James Smart
2017-10-05  8:00   ` Christoph Hellwig
2017-10-07 16:08     ` James Smart
2017-10-11 10:17       ` Sagi Grimberg
2017-10-11 15:10         ` James Smart
2017-10-11 10:14   ` Sagi Grimberg
2017-09-27  4:50 ` [PATCH v2 5/7] nvme_fc: check connectivity before initiating reconnects James Smart
2017-10-05  8:01   ` Christoph Hellwig
2017-09-27  4:50 ` [PATCH v2 6/7] nvme_fc: move remote port get/put/free location James Smart
2017-10-05  8:03   ` Christoph Hellwig
2017-10-11 10:18   ` Sagi Grimberg
2017-09-27  4:50 ` [PATCH v2 7/7] nvme_fc: add dev_loss_tmo timeout and remoteport resume support James Smart
2017-10-11 10:29   ` Sagi Grimberg
2017-10-11 14:52     ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004082813.GA23467@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.