From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5686479908468712561==" MIME-Version: 1.0 From: Ingo Molnar To: lkp@lists.01.org Subject: Re: [lockdep] b09be676e0 BUG: unable to handle kernel NULL pointer dereference at 000001f2 Date: Wed, 04 Oct 2017 12:31:19 +0200 Message-ID: <20171004103119.sedmwqcfwu3ze5od@gmail.com> In-Reply-To: <20171004092052.ioixdexrsbbwvetr@hirez.programming.kicks-ass.net> List-Id: --===============5686479908468712561== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable * Peter Zijlstra wrote: > On Tue, Oct 03, 2017 at 07:18:24PM +0200, Ingo Molnar wrote: > > Yes, I'll do that tomorrow. I was always a bit unhappy about cross-rele= ase, > > because it breaks the 'owner task owns the lock' model. > = > Still, you can get real deadlocks with completions... > = > > Plus I don't think we found that many real bugs with it > = > Every bug found is one less bug. It did find a few. Certainly, but the total work saved by finding bugs should be balanced agai= nst the = additional fragility of lockdep and the ongoing maintenance cost. Thanks, Ingo --===============5686479908468712561==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbdJDKb0 (ORCPT ); Wed, 4 Oct 2017 06:31:26 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:51404 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916AbdJDKbX (ORCPT ); Wed, 4 Oct 2017 06:31:23 -0400 X-Google-Smtp-Source: AOwi7QDi4iAdnvWZbRe2LKLI6NajV37YJfXCLYrz0BwikEu49JyiGwecJqgcR/TkvIDbtEciJLRVHw== Date: Wed, 4 Oct 2017 12:31:19 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Linus Torvalds , Fengguang Wu , Byungchul Park , Linux Kernel Mailing List , LKP , Josh Poimboeuf Subject: Re: [lockdep] b09be676e0 BUG: unable to handle kernel NULL pointer dereference at 000001f2 Message-ID: <20171004103119.sedmwqcfwu3ze5od@gmail.com> References: <20171003140634.r2jzujgl62ox4uzh@wfg-t540p.sh.intel.com> <20171003171824.te5cxms2hq634tvi@gmail.com> <20171004092052.ioixdexrsbbwvetr@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171004092052.ioixdexrsbbwvetr@hirez.programming.kicks-ass.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Tue, Oct 03, 2017 at 07:18:24PM +0200, Ingo Molnar wrote: > > Yes, I'll do that tomorrow. I was always a bit unhappy about cross-release, > > because it breaks the 'owner task owns the lock' model. > > Still, you can get real deadlocks with completions... > > > Plus I don't think we found that many real bugs with it > > Every bug found is one less bug. It did find a few. Certainly, but the total work saved by finding bugs should be balanced against the additional fragility of lockdep and the ongoing maintenance cost. Thanks, Ingo