From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH] net/mlx5: fix checksum offload cap Date: Wed, 4 Oct 2017 14:02:33 +0200 Message-ID: <20171004120233.GK1343@autoinstall.dev.6wind.com> References: <20171004082843.66576-1-shahafs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: yskoh@mellanox.com, dev@dpdk.org, shacharbe@mellanox.com To: Shahaf Shuler Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id CFD2A1B617 for ; Wed, 4 Oct 2017 14:02:44 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id b189so18436491wmd.4 for ; Wed, 04 Oct 2017 05:02:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20171004082843.66576-1-shahafs@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 04, 2017 at 11:28:43AM +0300, Shahaf Shuler wrote: > The PMD was using the wrong flag to query device checksum capabilities > > Fixes: bba710e6b99b ("net/mlx5: support upstream rdma-core") > Cc: shacharbe@mellanox.com > > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 229b824bc..a4b718417 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -649,8 +649,8 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > } > > priv->hw_csum = > - ((device_attr_ex.device_cap_flags_ex & > - IBV_DEVICE_UD_IP_CSUM)); > + !!(device_attr_ex.device_cap_flags_ex & > + IBV_DEVICE_RAW_IP_CSUM); > DEBUG("checksum offloading is %ssupported", > (priv->hw_csum ? "" : "not ")); > > -- > 2.12.0 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND