From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
Sergej Sawazki <ce3a@gmx.de>, Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH 1/2] clk: clk-gpio: Make GPIO clock provider use descriptors only
Date: Wed, 4 Oct 2017 14:21:50 -0700 [thread overview]
Message-ID: <20171004212150.GY457@codeaurora.org> (raw)
In-Reply-To: <CACRpkdZD9ApuYvatx9y4hVnHoRDBPFKrYvQnQemM8URZnVJ8NA@mail.gmail.com>
On 10/01, Linus Walleij wrote:
> On Sat, Sep 30, 2017 at 12:57 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 09/24, Linus Walleij wrote:
>
> >> I don't have GPIO clocks in my setups so this will obviously
> >> need some testing.
> >>
> >> I guess the public APIs in clk-provider.h could actually be
> >> removed, but I'm not certain if that is proper. Maybe there
> >> are plans for this driver to be used by other providers than the
> >> device tree.
> >
> > If nobody is using them it's fine to remove them. This falls into
> > another "basic clk type" that Mike and I don't really like to
> > keep around.
>
> I started to make a patch for it, removing the non-clk_hw* portions
> so that at least only the *hw* infix versions would be around.
> (I guess that is what you want to optimally keep around.)
>
> It became a bit complex since this driver itself is using the
> non-hw calls, and with not being able to test it I chickened out.
>
> But if you like the idea, I can make a second attempt (on top of
> these two patches), especially if someone volunteers to test it.
I don't know if anyone is going to test it. We have only a
handful of users in mainline. I'll just merge these patches and
you can remove the non-clk_hw portions later if you're
interested.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-10-04 21:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 16:19 [PATCH 1/2] clk: clk-gpio: Make GPIO clock provider use descriptors only Linus Walleij
2017-09-24 16:19 ` [PATCH 2/2] clk: clk-gpio: Request GPIO descriptor as LOW Linus Walleij
2017-09-29 22:53 ` Stephen Boyd
2017-10-01 14:50 ` Linus Walleij
2017-11-02 8:21 ` Stephen Boyd
2017-09-29 22:57 ` [PATCH 1/2] clk: clk-gpio: Make GPIO clock provider use descriptors only Stephen Boyd
2017-10-01 14:53 ` Linus Walleij
2017-10-04 21:21 ` Stephen Boyd [this message]
2017-11-02 8:21 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004212150.GY457@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=ce3a@gmx.de \
--cc=jsarha@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.