From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbdJEMnp (ORCPT ); Thu, 5 Oct 2017 08:43:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21969 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbdJEMno (ORCPT ); Thu, 5 Oct 2017 08:43:44 -0400 Date: Thu, 5 Oct 2017 15:43:33 +0300 From: Dan Carpenter To: Srinivasan Shanmugam Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Staging: rtl8723bs: Externs should be avoided in .C file Message-ID: <20171005124333.z2msohwvyjicmikj@mwanda> References: <1507149242-3269-1-git-send-email-srinivasan.rns@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507149242-3269-1-git-send-email-srinivasan.rns@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 04, 2017 at 10:34:02PM +0200, Srinivasan Shanmugam wrote: > Removed all the unnecessary extern from rtl8723bs > The patch is good but doesn't match the description. regards, dan carpenter