From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S80-V3 04/11] i40e/i40evf: always set the CLEARPBA flag when re-enabling interrupts
Date: Thu, 5 Oct 2017 16:01:29 -0700 [thread overview]
Message-ID: <20171005160129.0000606a@intel.com> (raw)
In-Reply-To: <02874ECE860811409154E81DA85FBB5882ABC495@ORSMSX115.amr.corp.intel.com>
On Thu, 5 Oct 2017 22:24:19 +0000
"Keller, Jacob E" <jacob.e.keller@intel.com> wrote:
> > The original patch was more aggressive than it needed to be. For
> > example you could probably go ahead and clear the PBA in the
> > i40e_intr()q interrupt routine itself since all it is doing is
> > scheduling the polling routine which will run after the interrupt
> > routine has completed. You shouldn't be clearing the PBA at the end of
> > NAPI poll unless you know you are not going to be exiting polling.
> >
> > I hope this helps to clarify things.
> >
> > - Alex
>
> Ok so only clear it if we're continuing to poll. I'll cook up a patch for that.
Hi Jake, we may just need to cook up a better test for this instead of
generating further patches. I believe based on updated understanding
of the hardware functionality that this patch is correct, but it is
difficult to prove and we should probably spend more time doing the
actual proof.
At least this patch follow the actual directions in the hardware
manual, so I think we should stick with it.
Jesse
next prev parent reply other threads:[~2017-10-05 23:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 12:05 [Intel-wired-lan] [next PATCH S80-V3 01/11] i40e: use the safe hash table iterator when deleting mac filters Alice Michael
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 02/11] i40evf: fix mac filter removal timing issue Alice Michael
2017-09-12 20:23 ` Bowers, AndrewX
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 03/11] i40e/i40evf: fix incorrect default ITR values on driver load Alice Michael
2017-09-12 20:30 ` Bowers, AndrewX
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 04/11] i40e/i40evf: always set the CLEARPBA flag when re-enabling interrupts Alice Michael
2017-09-12 20:46 ` Bowers, AndrewX
2017-10-05 18:31 ` Duyck, Alexander H
2017-10-05 22:24 ` Keller, Jacob E
2017-10-05 23:01 ` Jesse Brandeburg [this message]
2017-10-05 23:25 ` Keller, Jacob E
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 05/11] i40e: reduce lrxqthresh from 2 to 1 Alice Michael
2017-09-12 21:33 ` Bowers, AndrewX
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 06/11] i40e/i40evf: bump tail only in multiples of 8 Alice Michael
2017-09-12 21:40 ` Bowers, AndrewX
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 07/11] i40e/i40evf: bundle more descriptors when allocating buffers Alice Michael
2017-09-12 21:41 ` Bowers, AndrewX
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 08/11] i40e: allow XPS with QoS enabled Alice Michael
2017-09-12 21:47 ` Bowers, AndrewX
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 09/11] i40e: add check for return from find_first_bit call Alice Michael
2017-09-12 21:48 ` Bowers, AndrewX
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 10/11] i40e: Retry AQC GetPhyAbilities to overcome I2CRead hangs Alice Michael
2017-09-12 22:15 ` Bowers, AndrewX
2017-09-07 12:05 ` [Intel-wired-lan] [next PATCH S80-V3 11/11] i40e: use a local variable instead of calculating multiple times Alice Michael
2017-09-12 21:52 ` Bowers, AndrewX
2017-09-12 16:53 ` [Intel-wired-lan] [next PATCH S80-V3 01/11] i40e: use the safe hash table iterator when deleting mac filters Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005160129.0000606a@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.