All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Javier González" <jg@lightnvm.io>
Cc: "Christoph Hellwig" <hch@infradead.org>,
	"Matias Bjørling" <m@bjorling.me>,
	linux-block@vger.kernel.org
Subject: Re: Why removing REQ_FAILFAST_DRIVER in LightNVM?
Date: Fri, 6 Oct 2017 04:59:27 -0700	[thread overview]
Message-ID: <20171006115927.GA12530@infradead.org> (raw)
In-Reply-To: <216FF7C0-4B2A-438A-BC63-88A9BBDC77CC@lightnvm.io>

On Fri, Oct 06, 2017 at 11:19:09AM +0200, Javier Gonz�lez wrote:
> on the lightnvm I/O path and that has propagated through the code as we
> added more functionality. Can you explain why this is necessary? If I
> can just remove it, it is much easier to do the cleanup.
> 
> I have tested on or HW and all works fine without it.

nvme_alloc_request always sets REQ_FAILFAST_DRIVER and that srops
it to stick to the previous behavior.

If you actually want all your lightnvm requests to fail fast you can
remove it.

  reply	other threads:[~2017-10-06 11:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06  9:19 Why removing REQ_FAILFAST_DRIVER in LightNVM? Javier González
2017-10-06 11:59 ` Christoph Hellwig [this message]
2017-10-06 12:01   ` Javier González
2017-10-06 12:06     ` Christoph Hellwig
2017-10-06 12:08       ` Javier González
2017-10-06 12:12         ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171006115927.GA12530@infradead.org \
    --to=hch@infradead.org \
    --cc=jg@lightnvm.io \
    --cc=linux-block@vger.kernel.org \
    --cc=m@bjorling.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.