From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mark Santaniello <marksan@fb.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bugfix perf script -F ip,brstack (and brstackoff)
Date: Fri, 6 Oct 2017 09:25:07 -0300 [thread overview]
Message-ID: <20171006122507.GA28623@kernel.org> (raw)
In-Reply-To: <20171006080722.3442046-1-marksan@fb.com>
Em Fri, Oct 06, 2017 at 01:07:22AM -0700, Mark Santaniello escreveu:
> Prior to commit 55b9b50811ca ("perf script: Support -F brstack,dso and
> brstacksym,dso"), we were printing a space before the brstack data. It
> seems that this space was important. Without it, parsing is difficult.
>
> Very sorry for the mistake.
Thanks, applied and added:
Cc: 4.13+ <stable@vger.kernel.org>
As:
[acme@jouet linux]$ git tag --contains 55b9b50811ca | grep ^v4
v4.13
v4.13-rc1
v4.13-rc2
v4.13-rc3
v4.13-rc4
v4.13-rc5
v4.13-rc6
v4.13-rc7
v4.14-rc1
v4.14-rc2
v4.14-rc3
[acme@jouet linux]$
> Notice here how the "ip" and "brstack" run together:
>
> $ perf script -F ip,brstack | head -n 1
> 22e18c40x22e19e2/0x22e190b/P/-/-/0 0x22e19a1/0x22e19d0/P/-/-/0 0x22e195d/0x22e1990/P/-/-/0 0x22e18e9/0x22e1943/P/-/-/0 0x22e1a69/0x22e18c0/P/-/-/0 0x22e19f7/0x22e1a20/P/-/-/0 0x22e1910/0x22e19ee/P/-/-/0 0x22e19e2/0x22e190b/P/-/-/0 0x22e19a1/0x22e19d0/P/-/-/0 0x22e195d/0x22e1990/P/-/-/0 0x22e18e9/0x22e1943/P/-/-/0 0x22e1a69/0x22e18c0/P/-/-/0 0x22e19f7/0x22e1a20/P/-/-/0 0x22e1910/0x22e19ee/P/-/-/0 0x22e19e2/0x22e190b/P/-/-/0 0x22e19a1/0x22e19d0/P/-/-/0
>
> After this diff, sanity is restored:
>
> $ perf script -F ip,brstack | head -n 1
> 22e18c4 0x22e19e2/0x22e190b/P/-/-/0 0x22e19a1/0x22e19d0/P/-/-/0 0x22e195d/0x22e1990/P/-/-/0 0x22e18e9/0x22e1943/P/-/-/0 0x22e1a69/0x22e18c0/P/-/-/0 0x22e19f7/0x22e1a20/P/-/-/0 0x22e1910/0x22e19ee/P/-/-/0 0x22e19e2/0x22e190b/P/-/-/0 0x22e19a1/0x22e19d0/P/-/-/0 0x22e195d/0x22e1990/P/-/-/0 0x22e18e9/0x22e1943/P/-/-/0 0x22e1a69/0x22e18c0/P/-/-/0 0x22e19f7/0x22e1a20/P/-/-/0 0x22e1910/0x22e19ee/P/-/-/0 0x22e19e2/0x22e190b/P/-/-/0 0x22e19a1/0x22e19d0/P/-/-/0
>
> Signed-off-by: Mark Santaniello <marksan@fb.com>
> ---
> tools/perf/builtin-script.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 3d4c3b5..0c977b6 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -586,7 +586,7 @@ static void print_sample_brstack(struct perf_sample *sample,
> thread__find_addr_map(thread, sample->cpumode, MAP__FUNCTION, to, &alt);
> }
>
> - printf("0x%"PRIx64, from);
> + printf(" 0x%"PRIx64, from);
> if (PRINT_FIELD(DSO)) {
> printf("(");
> map__fprintf_dsoname(alf.map, stdout);
> @@ -681,7 +681,7 @@ static void print_sample_brstackoff(struct perf_sample *sample,
> if (alt.map && !alt.map->dso->adjust_symbols)
> to = map__map_ip(alt.map, to);
>
> - printf("0x%"PRIx64, from);
> + printf(" 0x%"PRIx64, from);
> if (PRINT_FIELD(DSO)) {
> printf("(");
> map__fprintf_dsoname(alf.map, stdout);
> --
> 2.9.5
next prev parent reply other threads:[~2017-10-06 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 8:07 [PATCH] Bugfix perf script -F ip,brstack (and brstackoff) Mark Santaniello
2017-10-06 12:25 ` Arnaldo Carvalho de Melo [this message]
2017-10-10 17:28 ` [tip:perf/urgent] perf script: Add missing separator for "-F ip,brstack" " tip-bot for Mark Santaniello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006122507.GA28623@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marksan@fb.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.