From: Cornelia Huck <cohuck@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: Bug 1721744 <1721744@bugs.launchpad.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1721744] Re: Help content missing for newly added machine properties
Date: Fri, 6 Oct 2017 13:49:52 +0200 [thread overview]
Message-ID: <20171006134952.63076c08.cohuck@redhat.com> (raw)
In-Reply-To: <150728886813.8130.14646885344900219104.malone@wampee.canonical.com>
On Fri, 06 Oct 2017 11:21:08 -0000
Greg Kurz <groug@kaod.org> wrote:
> Hmm... -h is common to all targets, ie, you should only find properties
> that can be passed to -machine for all qemu-system-* binaries (I don't
> know how s390-squash-mcss landed there but it looks wrong).
That output comes from qemu-options.hx, which contains information
added by hand. That means that some machine options end up there, some
don't. If this is only supposed to contain common options, we should
remove s390-squash-mcss (and the -key-wrap ones are s390-specific as
well).
>
> The right way to query properties supported by a pseries machine type
> is:
>
> $ ./ppc64-softmmu/qemu-system-ppc64 -machine pseries,help
Indeed. This contains the real set of properties and does not depend on
whether a developer added some extra help text.
next prev parent reply other threads:[~2017-10-06 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 10:29 [Qemu-devel] [Bug 1721744] [NEW] Help content missing for newly added machine properties Satheesh Rajendran
2017-10-06 11:21 ` [Qemu-devel] [Bug 1721744] " Greg Kurz
2017-10-06 11:49 ` Cornelia Huck [this message]
2017-10-06 12:25 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006134952.63076c08.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=1721744@bugs.launchpad.net \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.