From: Tim Hansen <devtimhansen@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
alexander.levin@one.verizon.com
Subject: Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()
Date: Fri, 6 Oct 2017 18:26:57 -0400 [thread overview]
Message-ID: <20171006222629.GA30627@debian> (raw)
In-Reply-To: <a1d52c34-6d06-1142-0d3e-2604e15ed993@kernel.dk>
On Fri, Oct 06, 2017 at 01:04:25PM -0600, Jens Axboe wrote:
> On 10/05/2017 12:09 PM, Tim Hansen wrote:
> > mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks.
> >
> > This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch).
>
> Applied, but I had to fix up your commit message. Please line wrap at
> 72 chars, otherwise it turns into an unreadable mess when people
> try to view them.
>
> --
> Jens Axboe
>
Noted! Thanks for the heads up on the char limit.
next prev parent reply other threads:[~2017-10-06 22:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 18:09 [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free() Tim Hansen
2017-10-06 16:00 ` Kyle Fortin
2017-10-06 16:00 ` Kyle Fortin
2017-10-06 18:40 ` Martin K. Petersen
2017-10-06 19:04 ` Jens Axboe
2017-10-06 22:26 ` Tim Hansen [this message]
2017-10-09 18:34 ` Kyle Fortin
2017-10-09 18:34 ` Kyle Fortin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006222629.GA30627@debian \
--to=devtimhansen@gmail.com \
--cc=alexander.levin@one.verizon.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.