All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] parted: properly link with libiconv
Date: Sun, 8 Oct 2017 15:30:40 +0200	[thread overview]
Message-ID: <20171008153040.5700dfea@windsurf> (raw)
In-Reply-To: <20171007230611.25347-1-arnout@mind.be>

Hello,

On Sun, 8 Oct 2017 01:06:11 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> parted uses libiconv but doesn't link with it. All the checks are there
> in configure, but the Makefile.am doesn't add it to the link. Add a
> patch to fix this.
> 
> Also add an optional dependency on libiconv, so it is reproducible.
> 
> While we're at it, regenerate the existing patches on top of v3.2, and
> make patch 0003 a properly git formatted one.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: srg.venema at gmail.com
> ---
>  ...rch-linux.c-Compile-without-ENABLE_DEVICE.patch |  8 ++---
>  .../0002-configure.ac-uclinux-is-also-linux.patch  |  4 +--
>  ...Include-fcntl.h-to-get-loff_t-definition.patch} | 19 ++++++++----
>  ...arted-labels-link-with-libiconv-if-needed.patch | 34 ++++++++++++++++++++++
>  package/parted/parted.mk                           |  7 ++++-
>  5 files changed, 60 insertions(+), 12 deletions(-)
>  rename package/parted/{0003-fix-includes-for-musl.patch => 0003-Include-fcntl.h-to-get-loff_t-definition.patch} (36%)
>  create mode 100644 package/parted/0004-libparted-labels-link-with-libiconv-if-needed.patch

Applied to master, thanks. Don't forget to send the patch upstream.
Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2017-10-08 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-07 23:06 [Buildroot] [PATCH] parted: properly link with libiconv Arnout Vandecappelle
2017-10-08 13:30 ` Thomas Petazzoni [this message]
2017-10-08 21:09 ` Thomas Petazzoni
     [not found]   ` <CAPzckP6FYH1rQPVnaozWg167THtdhovB7nYtX=XVe5_yM7W2Gg@mail.gmail.com>
2017-10-10 10:23     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171008153040.5700dfea@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.