From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, imammedo@redhat.com, ehabkost@redhat.com,
mst@redhat.com, anderson@redhat.com, lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device
Date: Mon, 9 Oct 2017 12:03:36 +0100 [thread overview]
Message-ID: <20171009110336.GA17824@redhat.com> (raw)
In-Reply-To: <20170911165929.2791-3-marcandre.lureau@redhat.com>
On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote:
> See docs/specs/vmcoreinfo.txt for details.
>
> "etc/vmcoreinfo" fw_cfg entry is added when using "-device vmcoreinfo".
I'm wondering if you considered just adding the entry to fw_cfg by
default, without requiring any -device arg ? Unless I'm misunderstanding,
this doesn't feel like a device to me - its just a well known bucket
in fw_cfg IIUC ? Obviously its existance would need to be tied to
the latest machine type for ABI reasons though. The benefit of this
is that it would "just work" without us having to plumb it through to
all the downstream applications that use QEMU for mgmt guest (OpenStack,
oVirt, GNOME Boxes, virt-manager, and countless other mgmt apps).
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-10-09 11:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 16:59 [Qemu-devel] [PATCH v6 0/7] KASLR kernel dump support Marc-André Lureau
2017-09-11 16:59 ` [Qemu-devel] [PATCH v6 1/7] fw_cfg: add write callback Marc-André Lureau
2017-09-11 16:59 ` [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device Marc-André Lureau
2017-10-09 11:03 ` Daniel P. Berrange [this message]
2017-10-09 11:46 ` Marc-André Lureau
2017-10-09 12:43 ` Igor Mammedov
2017-10-09 13:02 ` Daniel P. Berrange
2017-10-09 21:44 ` Michael S. Tsirkin
2017-10-10 8:31 ` Daniel P. Berrange
2017-10-10 15:00 ` Marc-André Lureau
2017-10-10 15:03 ` Michael S. Tsirkin
2017-10-10 15:06 ` Daniel P. Berrange
2017-10-10 15:21 ` Michael S. Tsirkin
2017-10-10 18:01 ` Eduardo Habkost
2017-10-15 1:56 ` Michael S. Tsirkin
2017-10-20 18:48 ` Eduardo Habkost
2018-04-17 19:12 ` Cole Robinson
2018-04-17 21:11 ` Eduardo Habkost
2018-04-17 22:31 ` Cole Robinson
2018-04-17 22:53 ` Eduardo Habkost
2017-10-15 2:02 ` Michael S. Tsirkin
2017-10-10 19:15 ` Eduardo Habkost
2017-09-11 16:59 ` [Qemu-devel] [PATCH v6 3/7] dump: add guest ELF note Marc-André Lureau
2017-09-11 16:59 ` [Qemu-devel] [PATCH v6 4/7] dump: update phys_base header field based on VMCOREINFO content Marc-André Lureau
2017-09-11 16:59 ` [Qemu-devel] [PATCH v6 5/7] kdump: set vmcoreinfo location Marc-André Lureau
2017-09-11 16:59 ` [Qemu-devel] [PATCH v6 6/7] scripts/dump-guest-memory.py: add vmcoreinfo Marc-André Lureau
2017-09-11 16:59 ` [Qemu-devel] [PATCH v6 7/7] MAINTAINERS: add Dump maintainers Marc-André Lureau
2017-09-25 10:52 ` [Qemu-devel] [PATCH v6 0/7] KASLR kernel dump support Marc-André Lureau
2017-10-09 10:57 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009110336.GA17824@redhat.com \
--to=berrange@redhat.com \
--cc=anderson@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.