From: Johan Hovold <johan@kernel.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Johan Hovold <johan@kernel.org>,
USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect
Date: Mon, 9 Oct 2017 13:10:34 +0200 [thread overview]
Message-ID: <20171009111034.GA3801@localhost> (raw)
In-Reply-To: <CAAeHK+zDy66VEbfH+MV9PcUiWwGoqJX+5wW3Kk5bVXF-gyzbBw@mail.gmail.com>
On Mon, Oct 09, 2017 at 01:05:30PM +0200, Andrey Konovalov wrote:
> On Wed, Oct 4, 2017 at 11:01 AM, Johan Hovold <johan@kernel.org> wrote:
> > A clean-up patch removing removing two redundant NULL-checks from the
> > console disconnect handler inadvertently also removed a third check.
> > This could lead to the struct usb_serial being prematurely freed by the
> > console code when a driver accepts but does not register any ports for
> > an interface which also lacks endpoint descriptors.
> >
> > Fixes: 0e517c93dc02 ("USB: serial: console: clean up sanity checks")
> > Cc: stable <stable@vger.kernel.org> # 4.11
> > Reported-by: Andrey Konovalov <andreyknvl@google.com>
>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
>
> This fixes the crash.
I just forwarded this one in a pull-request to Greg, but thanks for
testing nonetheless.
Johan
next prev parent reply other threads:[~2017-10-09 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 9:01 [PATCH 0/2] USB: serial: console: fix two use-after-free bugs Johan Hovold
2017-10-04 9:01 ` [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect Johan Hovold
2017-10-04 14:39 ` Greg KH
2017-10-07 8:56 ` Jaejoong Kim
2017-10-09 10:41 ` Johan Hovold
2017-10-09 11:05 ` Andrey Konovalov
2017-10-09 11:10 ` Johan Hovold [this message]
2017-10-04 9:01 ` [PATCH 2/2] USB: serial: console: fix use-after-free after failed setup Johan Hovold
2017-10-04 14:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009111034.GA3801@localhost \
--to=johan@kernel.org \
--cc=andreyknvl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.