From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [RFC] workqueue: Fix irq inversion deadlock in manage_workers()
Date: Mon, 9 Oct 2017 06:07:00 -0700 [thread overview]
Message-ID: <20171009130700.GY3301751@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171009064257.43lfvc4ey7xrr7hz@hirez.programming.kicks-ass.net>
On Mon, Oct 09, 2017 at 08:42:57AM +0200, Peter Zijlstra wrote:
> On Sun, Oct 08, 2017 at 12:03:47PM -0700, Tejun Heo wrote:
> > So, if I'm not mistaken, this is a regression caused by b9c16a0e1f73
> > ("locking/mutex: Fix lockdep_assert_held() fail") which seems to
> > replace irqsave operations inside mutex to unconditional irq ones.
>
> No, it existed before that. You're looking at the DEBUG_MUTEX case, the
> normal case looked like:
Ah, I see. That mutex usage was a stretch anyway. I'll get rid of
it.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-10-09 13:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 9:02 [RFC] workqueue: Fix irq inversion deadlock in manage_workers() Boqun Feng
2017-10-08 19:03 ` Tejun Heo
2017-10-09 3:24 ` Boqun Feng
2017-10-09 6:42 ` Peter Zijlstra
2017-10-09 13:07 ` Tejun Heo [this message]
2017-10-09 9:40 ` Lai Jiangshan
2017-10-09 12:40 ` Boqun Feng
2017-10-09 15:24 ` Peter Zijlstra
2017-10-09 15:29 ` Tejun Heo
2017-10-09 13:21 ` [PATCH workqueue/for-4.14-fixes] workqueue: replace pool->manager_arb mutex with a flag Tejun Heo
2017-10-09 14:21 ` Boqun Feng
2017-10-09 14:47 ` Tejun Heo
2017-10-09 15:02 ` Lai Jiangshan
2017-10-09 15:08 ` Tejun Heo
2017-10-09 15:14 ` Lai Jiangshan
2017-10-09 15:33 ` Tejun Heo
2017-10-09 15:04 ` [PATCH v2 " Tejun Heo
2017-10-10 9:55 ` Lai Jiangshan
2017-10-10 14:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009130700.GY3301751@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=josef@toxicpanda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.