From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <segher@gate.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 3y9kFc2HqbzDqlv
 for <linuxppc-dev@lists.ozlabs.org>; Tue, 10 Oct 2017 02:10:27 +1100 (AEDT)
Date: Mon, 9 Oct 2017 09:20:53 -0500
From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Sandipan Das'" <sandipan@linux.vnet.ibm.com>,
 "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
 "paulus@samba.org" <paulus@samba.org>,
 "naveen.n.rao@linux.vnet.ibm.com" <naveen.n.rao@linux.vnet.ibm.com>,
 "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
 "anton@samba.org" <anton@samba.org>
Subject: Re: [PATCH] powerpc/lib/sstep: Fix count leading zeros instructions
Message-ID: <20171009142053.GA4406@gate.crashing.org>
References: <20171009110726.28551-1-sandipan@linux.vnet.ibm.com>
 <063D6719AE5E284EB5DD2968C1650D6DD008D92D@AcuExch.aculab.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD008D92D@AcuExch.aculab.com>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

On Mon, Oct 09, 2017 at 01:49:26PM +0000, David Laight wrote:
> From: Sandipan Das
> > Sent: 09 October 2017 12:07
> > According to the GCC documentation, the behaviour of __builtin_clz()
> > and __builtin_clzl() is undefined if the value of the input argument
> > is zero. Without handling this special case, these builtins have been
> > used for emulating the following instructions:
> >   * Count Leading Zeros Word (cntlzw[.])
> >   * Count Leading Zeros Doubleword (cntlzd[.])
> > 
> > This fixes the emulated behaviour of these instructions by adding an
> > additional check for this special case.
> 
> Presumably the result is undefined because the underlying cpu
> instruction is used - and it's return value is implementation defined.

It is undefined because the result is undefined, and the compiler
optimises based on that.  The return value of the builtin is undefined,
not implementation defined.

The patch is correct.


Segher