From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: igor.mitsyanko.os@quantenna.com
Cc: linux-wireless@vger.kernel.org, avinashp@quantenna.com,
johannes@sipsolutions.net
Subject: Re: [PATCH V2 0/8] qtnfmac: get rid of redundant state caching in driver
Date: Mon, 9 Oct 2017 19:00:35 +0300 [thread overview]
Message-ID: <20171009160033.o734uvdguk62yapx@bars> (raw)
In-Reply-To: <20171005013813.13332-1-igor.mitsyanko.os@quantenna.com>
> In many cases qtnfmac driver stores state info (like current channel,
> interface state) in driver's internal state that is either unused or
> duplicates information that is available elsewhere. Cleanup driver
> to get rid of not needed cached data.
>
> It was part of bigger changeset when it was V1.
>
> Changelist V1->V2:
> PATCH 3:
> - add missing cpu_to_le16() to CMD len field initialization.
>
> Igor Mitsyanko (8):
> qtnfmac: do not cache AP settings in driver structures
> qtnfmac: pass all AP settings to wireless card for processing
> qtnfmac: pass channel definition to WiFi card on START_AP command
> qtnfmac: get rid of QTNF_STATE_AP_CONFIG
> qtnfmac: get rid of QTNF_STATE_AP_START flag
> qtnfmac: do not cache BSS state in per-VIF structure
> qtnfmac: make encryption info a part of CONNECT command.
> qtnfmac: do not cache current channel info in driver's state
>
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 110 ++------------
> drivers/net/wireless/quantenna/qtnfmac/commands.c | 163 +++++++++++----------
> drivers/net/wireless/quantenna/qtnfmac/commands.h | 3 +-
> drivers/net/wireless/quantenna/qtnfmac/core.h | 24 +--
> drivers/net/wireless/quantenna/qtnfmac/event.c | 14 --
> drivers/net/wireless/quantenna/qtnfmac/qlink.h | 92 +++++++++---
> .../net/wireless/quantenna/qtnfmac/qlink_util.c | 45 ++++++
> .../net/wireless/quantenna/qtnfmac/qlink_util.h | 3 +
> 8 files changed, 224 insertions(+), 230 deletions(-)
For the whole patchset:
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
prev parent reply other threads:[~2017-10-09 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 1:38 [PATCH V2 0/8] qtnfmac: get rid of redundant state caching in driver igor.mitsyanko.os
2017-10-05 1:38 ` [PATCH V2 1/8] qtnfmac: do not cache AP settings in driver structures igor.mitsyanko.os
2017-10-13 10:00 ` [V2,1/8] " Kalle Valo
2017-10-05 1:38 ` [PATCH V2 2/8] qtnfmac: pass all AP settings to wireless card for processing igor.mitsyanko.os
2017-10-05 1:38 ` [PATCH V2 3/8] qtnfmac: pass channel definition to WiFi card on START_AP command igor.mitsyanko.os
2017-10-05 1:38 ` [PATCH V2 4/8] qtnfmac: get rid of QTNF_STATE_AP_CONFIG igor.mitsyanko.os
2017-10-05 1:38 ` [PATCH V2 5/8] qtnfmac: get rid of QTNF_STATE_AP_START flag igor.mitsyanko.os
2017-10-05 1:38 ` [PATCH V2 6/8] qtnfmac: do not cache BSS state in per-VIF structure igor.mitsyanko.os
2017-10-05 1:38 ` [PATCH V2 7/8] qtnfmac: make encryption info a part of CONNECT command igor.mitsyanko.os
2017-10-05 1:38 ` [PATCH V2 8/8] qtnfmac: do not cache current channel info in driver's state igor.mitsyanko.os
2017-10-09 16:00 ` Sergey Matyukevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009160033.o734uvdguk62yapx@bars \
--to=sergey.matyukevich.os@quantenna.com \
--cc=avinashp@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.