From: Rob Herring <robh@kernel.org>
To: dri-devel@lists.freedesktop.org
Subject: [PATCH hwc] drm_hwcomposer: fix return values for ValidateDisplay
Date: Mon, 9 Oct 2017 11:06:04 -0500 [thread overview]
Message-ID: <20171009160604.24008-1-robh@kernel.org> (raw)
According to the API documentation, if we've set num_types, then the
return value should be HWC2::Error::HasChanges.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drmhwctwo.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drmhwctwo.cpp b/drmhwctwo.cpp
index 89399bf1ba33..0f258770a8bb 100644
--- a/drmhwctwo.cpp
+++ b/drmhwctwo.cpp
@@ -701,7 +701,7 @@ HWC2::Error DrmHwcTwo::HwcDisplay::ValidateDisplay(uint32_t *num_types,
break;
}
}
- return HWC2::Error::None;
+ return *num_types ? HWC2::Error::HasChanges : HWC2::Error::None;
}
HWC2::Error DrmHwcTwo::HwcLayer::SetCursorPosition(int32_t x, int32_t y) {
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
reply other threads:[~2017-10-09 16:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009160604.24008-1-robh@kernel.org \
--to=robh@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.