All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH hwc] drm_hwcomposer: fix return values for ValidateDisplay
@ 2017-10-09 16:06 Rob Herring
  0 siblings, 0 replies; only message in thread
From: Rob Herring @ 2017-10-09 16:06 UTC (permalink / raw)
  To: dri-devel

According to the API documentation, if we've set num_types, then the
return value should be HWC2::Error::HasChanges.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 drmhwctwo.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drmhwctwo.cpp b/drmhwctwo.cpp
index 89399bf1ba33..0f258770a8bb 100644
--- a/drmhwctwo.cpp
+++ b/drmhwctwo.cpp
@@ -701,7 +701,7 @@ HWC2::Error DrmHwcTwo::HwcDisplay::ValidateDisplay(uint32_t *num_types,
         break;
     }
   }
-  return HWC2::Error::None;
+  return *num_types ? HWC2::Error::HasChanges : HWC2::Error::None;
 }
 
 HWC2::Error DrmHwcTwo::HwcLayer::SetCursorPosition(int32_t x, int32_t y) {
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-10-09 16:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-09 16:06 [PATCH hwc] drm_hwcomposer: fix return values for ValidateDisplay Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.