From: Al Viro <viro@ZenIV.linux.org.uk>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] direct-io: Prevent NULL pointer access in submit_page_section
Date: Mon, 9 Oct 2017 17:22:22 +0100 [thread overview]
Message-ID: <20171009162222.GW21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171009091318.26714-1-agruenba@redhat.com>
On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote:
> In the code added to function submit_page_section by commit b1058b981,
> sdio->bio can currently be NULL when calling dio_bio_submit. This then
> leads to a NULL pointer access in dio_bio_submit, so check for a NULL
> bio in submit_page_section before trying to submit it instead.
>
> Fixes xfstest generic/250 on gfs2.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
How far back in -stable should it go? I'm fine with the patch, but I'd
rather have accurate Cc: stable in commit message...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
cluster-devel@redhat.com
Subject: Re: [PATCH] direct-io: Prevent NULL pointer access in submit_page_section
Date: Mon, 9 Oct 2017 17:22:22 +0100 [thread overview]
Message-ID: <20171009162222.GW21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171009091318.26714-1-agruenba@redhat.com>
On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote:
> In the code added to function submit_page_section by commit b1058b981,
> sdio->bio can currently be NULL when calling dio_bio_submit. This then
> leads to a NULL pointer access in dio_bio_submit, so check for a NULL
> bio in submit_page_section before trying to submit it instead.
>
> Fixes xfstest generic/250 on gfs2.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
How far back in -stable should it go? I'm fine with the patch, but I'd
rather have accurate Cc: stable in commit message...
next prev parent reply other threads:[~2017-10-09 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 9:13 [Cluster-devel] [PATCH] direct-io: Prevent NULL pointer access in submit_page_section Andreas Gruenbacher
2017-10-09 9:13 ` Andreas Gruenbacher
2017-10-09 16:22 ` Al Viro [this message]
2017-10-09 16:22 ` Al Viro
2017-10-09 18:24 ` [Cluster-devel] " Andreas Gruenbacher
2017-10-09 18:24 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009162222.GW21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.