From: Matthias Kaehlcke <mka@chromium.org>
To: Guenter Roeck <groeck@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'
Date: Mon, 9 Oct 2017 17:35:59 -0700 [thread overview]
Message-ID: <20171010003559.GS173745@google.com> (raw)
In-Reply-To: <CABXOdTdEH-=n8nf6a=0sC1iBeXLDKSxTXxoj1wUYmLUX_U=BUw@mail.gmail.com>
El Mon, Oct 09, 2017 at 05:18:32PM -0700 Guenter Roeck ha dit:
> On Mon, Oct 9, 2017 at 5:04 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> > This fixes the following error when building with clang:
> >
> > drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only
> > applies to functions, methods, properties, and global variables
> > static struct __init plat_sci_port port_cfg;
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > drivers/tty/serial/sh-sci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index 784dd42002ea..0d1df1df9e89 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -3244,7 +3244,7 @@ early_platform_init_buffer("earlyprintk", &sci_driver,
> > early_serial_buf, ARRAY_SIZE(early_serial_buf));
> > #endif
> > #ifdef CONFIG_SERIAL_SH_SCI_EARLYCON
> > -static struct __init plat_sci_port port_cfg;
> > +static struct plat_sci_port port_cfg;
>
> __initdata ?
Good point, thanks!
prev parent reply other threads:[~2017-10-10 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 0:04 [PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg' Matthias Kaehlcke
2017-10-10 0:18 ` Guenter Roeck
2017-10-10 0:35 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010003559.GS173745@google.com \
--to=mka@chromium.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.