From: Richard Kuo <rkuo@codeaurora.org>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-hexagon@vger.kernel.org
Subject: Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE
Date: Mon, 9 Oct 2017 20:26:08 -0500 [thread overview]
Message-ID: <20171010012608.GA23555@codeaurora.org> (raw)
In-Reply-To: <1507533107-2069-3-git-send-email-caoj.fnst@cn.fujitsu.com>
On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote:
> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is
> used to add arch-specific options for $(CC). From commandline,
> CFLAGS_MODULE shall be used.
> Doesn't have any functional change, but just follow kbuild rules.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> CC: Richard Kuo <rkuo@codeaurora.org>
> CC: linux-hexagon@vger.kernel.org
> ---
> arch/hexagon/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile
> index 207711a0..4f5c84c 100644
> --- a/arch/hexagon/Makefile
> +++ b/arch/hexagon/Makefile
> @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums
>
> # Modules must use either long-calls, or use pic/plt.
> # Use long-calls for now, it's easier. And faster.
> -# CFLAGS_MODULE += -fPIC
> -# LDFLAGS_MODULE += -shared
> -CFLAGS_MODULE += -mlong-calls
> +# KBUILD_CFLAGS_MODULE += -fPIC
> +# KBUILD_LDFLAGS_MODULE += -shared
> +KBUILD_CFLAGS_MODULE += -mlong-calls
>
> cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
> aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
> --
> 2.1.0
>
>
>
For Hexagon:
Acked-by: Richard Kuo <rkuo@codeaurora.org>
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-10-10 1:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 7:11 [PATCH 1/3] arm/kbuild: replace {C, LD}FLAGS_MODULE with KBUILD_{C, LD}FLAGS_MODULE Cao jin
2017-10-09 7:11 ` [PATCH 1/3] arm/kbuild: replace {C,LD}FLAGS_MODULE with KBUILD_{C,LD}FLAGS_MODULE Cao jin
2017-10-09 7:11 ` [PATCH 2/3] c6x/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE Cao jin
2017-10-30 15:42 ` Masahiro Yamada
2017-10-09 7:11 ` [PATCH 3/3] hexagon/kbuild: " Cao jin
2017-10-09 7:11 ` Cao jin
2017-10-10 1:26 ` Richard Kuo [this message]
2017-10-30 15:43 ` Masahiro Yamada
2017-10-30 15:41 ` [PATCH 1/3] arm/kbuild: replace {C, LD}FLAGS_MODULE with KBUILD_{C, LD}FLAGS_MODULE Masahiro Yamada
2017-10-30 15:41 ` [PATCH 1/3] arm/kbuild: replace {C,LD}FLAGS_MODULE with KBUILD_{C,LD}FLAGS_MODULE Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010012608.GA23555@codeaurora.org \
--to=rkuo@codeaurora.org \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.