Re: [PATCH 1/3] edt-ft5x06: fix reset pin behaviour

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Oct 05, 2017 at 05:35:06PM +0200, simon.budig@kernelconcepts.de wrote:
> From: Simon Budig <simon.budig@kernelconcepts.de>
> 
> For some reason the reset pin no longer gets toggeled when initializing
> the touch. Fix that and restore the old behaviour.

Hmm, the GPIO is requested as GPIOD_OUT_HIGH, so it should be driven low
to being with and then released... I am not sure why we need to drive it
low explicitly again.

> 
> Signed-off-by: Simon Budig <simon.budig@kernelconcepts.de>
> ---
>  drivers/input/touchscreen/edt-ft5x06.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index 5bf63f7..867a61e 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -936,8 +936,12 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client,
>  
>  	if (tsdata->reset_gpio) {
>  		usleep_range(5000, 6000);
> -		gpiod_set_value_cansleep(tsdata->reset_gpio, 0);
> +		/* note that the reset pin needs to be registered as
> +		 * active low in the devicetree.
> +		 */
> +		gpiod_set_value_cansleep(tsdata->reset_gpio, 1);
>  		msleep(300);
> +		gpiod_set_value_cansleep(tsdata->reset_gpio, 0);
>  	}
>  
>  	input = devm_input_allocate_device(&client->dev);
> -- 
> 2.1.4
> 

Thanks.

-- 
Dmitry