Re: [PATCH v2 15/16] gpio: tegra: Use banked GPIO infrastructure

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

On Mon, Oct 09, 2017 at 04:22:29PM -0500, Grygorii Strashko wrote:
> 
> 
> On 09/28/2017 04:56 AM, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > Convert the Tegra GPIO driver to use the banked GPIO infrastructure,
> > which simplifies some parts of the driver.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >   drivers/gpio/Kconfig      |   1 +
> >   drivers/gpio/gpio-tegra.c | 203 ++++++++++++++++++++++------------------------
> >   2 files changed, 98 insertions(+), 106 deletions(-)
> > 
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index db3e446ad9b3..458157d6d491 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -439,6 +439,7 @@ config GPIO_TEGRA
> >   	default ARCH_TEGRA
> >   	depends on ARCH_TEGRA || COMPILE_TEST
> 
> ... 
> 
> > @@ -616,76 +617,66 @@ static int tegra_gpio_probe(struct platform_device *pdev)
> >   	tgi->ic.irq_set_wake		= tegra_gpio_irq_set_wake;
> >   #endif
> >   
> > +	irq = &tgi->gc.irq;
> > +	irq->chip = &tgi->ic;
> > +	irq->handler = handle_simple_irq;
> > +	irq->lock_key = &tegra_gpio_lock_class;
> 
> As per current gpiolib design lockdep lock_class_key is assigned 
> automatically and hidden from gpiolib users. 
> Why do you need to do the same manually?

Can you elaborate? I don't see the lock class key getting set anywhere.
gpiolib does set if for interrupts, but only if the drivers assigned it
before adding the chip.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]