All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/8] libselinux: bump to 2.7
Date: Tue, 10 Oct 2017 10:35:40 +0200	[thread overview]
Message-ID: <20171010103540.44ee4777@windsurf.lan> (raw)
In-Reply-To: <8f8f5547-b7f4-8172-4989-36a5d8767c16@mind.be>

Hello,

On Tue, 10 Oct 2017 02:47:59 +0200, Arnout Vandecappelle wrote:

>  You update all the individual packages in separate patches, which is excellent
> for review. However, I wonder if it is really possible to update just one of
> them without updating the rest. Does libselinux-2.7 work with libsepol-2.7?
> 
>  If not, we should probably squash all patches into one single patch while
> applying. Thomas, Peter, do you agree?

I don't really have a strong opinion. I think it's sometimes hard to
achieve both full bisectability and fine-grained patches.

In the same vein, in your review of comment PATCH 5/8 on
policycoreutils, you rightfully tell Adam that the patch adding the new
restorecond should come *before* the bump of policycoreutils that drops
the built-in restorecond functionality. This is obviously correct, but
it means that there is a step where you have both the new restorecond
package and the old policycoreutils package, possibly stepping on each
other, or maybe even with restorecond not building (because it needs
the newer version of policycoreutils or something).

So, it's probably hard to have something that is both easy to review
(fine-grained patches) and bisectable (one big patch).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-10-10  8:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09 22:27 [Buildroot] [PATCH 1/8] libselinux: bump to 2.7 Adam Duskett
2017-10-09 22:27 ` [Buildroot] [PATCH 2/8] libsemanage: " Adam Duskett
2017-10-09 22:27 ` [Buildroot] [PATCH 3/8] libsepol: " Adam Duskett
2017-10-09 22:27 ` [Buildroot] [PATCH 4/8] Checkpolicy: " Adam Duskett
2017-10-09 22:27 ` [Buildroot] [PATCH 5/8] policycoreutils: " Adam Duskett
2017-10-10  0:15   ` Arnout Vandecappelle
2017-10-09 22:27 ` [Buildroot] [PATCH 6/8] sepolgen: Remove package Adam Duskett
2017-10-10  0:01   ` Arnout Vandecappelle
2017-10-09 22:27 ` [Buildroot] [PATCH 7/8] restorecond: new package Adam Duskett
2017-10-10  0:25   ` Arnout Vandecappelle
2017-10-09 22:27 ` [Buildroot] [PATCH 8/8] selinux-python: " Adam Duskett
2017-10-10  0:42   ` Arnout Vandecappelle
2017-10-10 14:10     ` Adam Duskett
2017-10-10  0:47 ` [Buildroot] [PATCH 1/8] libselinux: bump to 2.7 Arnout Vandecappelle
2017-10-10  8:35   ` Thomas Petazzoni [this message]
2017-10-10 10:20     ` Arnout Vandecappelle
2017-11-05 20:29       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171010103540.44ee4777@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.