From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler logic
Date: Tue, 10 Oct 2017 15:10:05 +0200 [thread overview]
Message-ID: <20171010151005.15dc7907.cohuck@redhat.com> (raw)
In-Reply-To: <20171004154144.88995-9-pasic@linux.vnet.ibm.com>
On Wed, 4 Oct 2017 17:41:44 +0200
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> Some of ioinst the handlers look very much the same: they basically
> delegate the work to the appropriate css function (doing some always the
> same stuff before and after the call to the appropriate css function).
> Let us create a template and get rid of some code.
>
> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> Suggested-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
> ---
> target/s390x/ioinst.c | 59 ++++++++++++---------------------------------------
> 1 file changed, 14 insertions(+), 45 deletions(-)
Staring at this patch, I'm not sure I like it, although I can't quite
put a finger on *what* I don't like... maybe the whole 'template'
approach.
next prev parent reply other threads:[~2017-10-10 13:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 15:41 [Qemu-devel] [PATCH v2 0/8] improve error handling for IO instr Halil Pasic
2017-10-04 15:41 ` [Qemu-devel] [PATCH v2 1/8] s390x/css: be more consistent if broken beyond repair Halil Pasic
2017-10-09 7:49 ` Dong Jia Shi
2017-10-10 13:25 ` Cornelia Huck
2017-10-10 14:39 ` Halil Pasic
2017-10-04 15:41 ` [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control Halil Pasic
2017-10-09 8:20 ` Thomas Huth
2017-10-09 10:54 ` Halil Pasic
2017-10-09 11:07 ` Thomas Huth
2017-10-09 15:00 ` Halil Pasic
2017-10-10 10:28 ` Thomas Huth
2017-10-10 11:39 ` Cornelia Huck
2017-10-10 11:48 ` Halil Pasic
2017-10-10 11:41 ` Halil Pasic
2017-10-12 6:58 ` Thomas Huth
2017-10-12 11:44 ` Halil Pasic
2017-10-17 11:10 ` Halil Pasic
2017-10-17 11:28 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2017-10-17 12:13 ` Cornelia Huck
2017-10-17 13:03 ` Halil Pasic
2017-10-09 11:09 ` [Qemu-devel] " Cornelia Huck
2017-10-09 15:19 ` Halil Pasic
2017-10-04 15:41 ` [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH Halil Pasic
2017-10-10 8:13 ` Dong Jia Shi
2017-10-10 10:06 ` Halil Pasic
2017-10-11 3:53 ` Dong Jia Shi
2017-10-10 13:07 ` Cornelia Huck
2017-10-10 14:36 ` Halil Pasic
2017-10-12 12:06 ` Halil Pasic
2017-10-12 12:11 ` Cornelia Huck
2017-10-12 12:17 ` Halil Pasic
2017-10-11 3:47 ` Dong Jia Shi
2017-10-11 10:54 ` Halil Pasic
2017-10-12 5:44 ` Dong Jia Shi
2017-10-04 15:41 ` [Qemu-devel] [PATCH v2 4/8] s390x: refactor error handling for XSCH handler Halil Pasic
2017-10-04 15:41 ` [Qemu-devel] [PATCH v2 5/8] s390x: refactor error handling for CSCH handler Halil Pasic
2017-10-04 15:41 ` [Qemu-devel] [PATCH v2 6/8] s390x: refactor error handling for HSCH handler Halil Pasic
2017-10-04 15:41 ` [Qemu-devel] [PATCH v2 7/8] s390x: refactor error handling for MSCH handler Halil Pasic
2017-10-04 15:41 ` [Qemu-devel] [PATCH v2 8/8] s390x: factor out common ioinst handler logic Halil Pasic
2017-10-10 13:10 ` Cornelia Huck [this message]
2017-10-10 14:37 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010151005.15dc7907.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.