From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1e1vHd-0007ez-Bd for mharc-qemu-trivial@gnu.org; Tue, 10 Oct 2017 10:13:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1vHX-0007b6-Er for qemu-trivial@nongnu.org; Tue, 10 Oct 2017 10:13:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1vHS-0001Sn-Ds for qemu-trivial@nongnu.org; Tue, 10 Oct 2017 10:13:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45872) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1vHH-0001Oa-2q; Tue, 10 Oct 2017 10:12:59 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAB8B2027C; Tue, 10 Oct 2017 14:12:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EAB8B2027C Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=imammedo@redhat.com Received: from nial.brq.redhat.com (unknown [10.43.2.209]) by smtp.corp.redhat.com (Postfix) with ESMTP id B255162952; Tue, 10 Oct 2017 14:12:45 +0000 (UTC) Date: Tue, 10 Oct 2017 16:12:44 +0200 From: Igor Mammedov To: Laurent Vivier Cc: qemu-trivial@nongnu.org, Eduardo Habkost , "Michael S . Tsirkin" , Michael Tokarev , qemu-devel@nongnu.org, Anthony Perard Message-ID: <20171010161244.056fef78@nial.brq.redhat.com> In-Reply-To: <20171010133241.11330-1-lvivier@redhat.com> References: <20171010133241.11330-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 10 Oct 2017 14:12:58 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] pc: remove useless hot_add_cpu initialisation X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 14:13:19 -0000 On Tue, 10 Oct 2017 15:32:41 +0200 Laurent Vivier wrote: > Since 4458fb3a79 (pc: Eliminate pc_default_machine_options()), > hot_add_cpu is set in pc_machine_class_init(), so we don't > need to set it in pc_q35_machine_options(), pc_i440fx_machine_options() > and xenfv_machine_options(), except to clear it in > pc_i440fx_1_4_machine_opt(). > > Signed-off-by: Laurent Vivier Reviewed-by: Igor Mammedov > --- > hw/i386/pc_piix.c | 2 -- > hw/i386/pc_q35.c | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 9ff79b1fd9..caf166aede 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -428,7 +428,6 @@ static void pc_i440fx_machine_options(MachineClass *m) > { > m->family = "pc_piix"; > m->desc = "Standard PC (i440FX + PIIX, 1996)"; > - m->hot_add_cpu = pc_hot_add_cpu; > m->default_machine_opts = "firmware=bios-256k.bin"; > m->default_display = "std"; > } > @@ -1123,7 +1122,6 @@ static void xenfv_machine_options(MachineClass *m) > m->desc = "Xen Fully-virtualized PC"; > m->max_cpus = HVM_MAX_VCPUS; > m->default_machine_opts = "accel=xen"; > - m->hot_add_cpu = pc_hot_add_cpu; > } > > DEFINE_PC_MACHINE(xenfv, "xenfv", pc_xen_hvm_init, > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 6c4ec4be4e..da3ea602e1 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -295,7 +295,6 @@ static void pc_q35_machine_options(MachineClass *m) > { > m->family = "pc_q35"; > m->desc = "Standard PC (Q35 + ICH9, 2009)"; > - m->hot_add_cpu = pc_hot_add_cpu; > m->units_per_default_bus = 1; > m->default_machine_opts = "firmware=bios-256k.bin"; > m->default_display = "std"; From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1vHM-0007Wp-Fi for qemu-devel@nongnu.org; Tue, 10 Oct 2017 10:13:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1vHH-0001Ot-9f for qemu-devel@nongnu.org; Tue, 10 Oct 2017 10:13:04 -0400 Date: Tue, 10 Oct 2017 16:12:44 +0200 From: Igor Mammedov Message-ID: <20171010161244.056fef78@nial.brq.redhat.com> In-Reply-To: <20171010133241.11330-1-lvivier@redhat.com> References: <20171010133241.11330-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pc: remove useless hot_add_cpu initialisation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-trivial@nongnu.org, Eduardo Habkost , "Michael S . Tsirkin" , Michael Tokarev , qemu-devel@nongnu.org, Anthony Perard On Tue, 10 Oct 2017 15:32:41 +0200 Laurent Vivier wrote: > Since 4458fb3a79 (pc: Eliminate pc_default_machine_options()), > hot_add_cpu is set in pc_machine_class_init(), so we don't > need to set it in pc_q35_machine_options(), pc_i440fx_machine_options() > and xenfv_machine_options(), except to clear it in > pc_i440fx_1_4_machine_opt(). > > Signed-off-by: Laurent Vivier Reviewed-by: Igor Mammedov > --- > hw/i386/pc_piix.c | 2 -- > hw/i386/pc_q35.c | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 9ff79b1fd9..caf166aede 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -428,7 +428,6 @@ static void pc_i440fx_machine_options(MachineClass *m) > { > m->family = "pc_piix"; > m->desc = "Standard PC (i440FX + PIIX, 1996)"; > - m->hot_add_cpu = pc_hot_add_cpu; > m->default_machine_opts = "firmware=bios-256k.bin"; > m->default_display = "std"; > } > @@ -1123,7 +1122,6 @@ static void xenfv_machine_options(MachineClass *m) > m->desc = "Xen Fully-virtualized PC"; > m->max_cpus = HVM_MAX_VCPUS; > m->default_machine_opts = "accel=xen"; > - m->hot_add_cpu = pc_hot_add_cpu; > } > > DEFINE_PC_MACHINE(xenfv, "xenfv", pc_xen_hvm_init, > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 6c4ec4be4e..da3ea602e1 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -295,7 +295,6 @@ static void pc_q35_machine_options(MachineClass *m) > { > m->family = "pc_q35"; > m->desc = "Standard PC (Q35 + ICH9, 2009)"; > - m->hot_add_cpu = pc_hot_add_cpu; > m->units_per_default_bus = 1; > m->default_machine_opts = "firmware=bios-256k.bin"; > m->default_display = "std";