From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/2] xfs: test support for xattr inactivate
Date: Tue, 10 Oct 2017 12:47:54 -0400 [thread overview]
Message-ID: <20171010164756.28390-1-bfoster@redhat.com> (raw)
Hi all,
This series adds some testability to the issue fixed by "xfs: reinit
btree pointer on attr tree inactivation walk." Patch 1 adds an assert
and patch 2 adds an error injection tag to disable buffer LRU caching. I
have an xfstests test that reproduces the aforementioned problem
reliably using the error injection tag.
Note that patch 1 is kind of a cautious attempt to detect the issue. I'm
wondering if the better fix is to pass -1 if we indeed should not ever
expect to hit a hole in this particular path. Thoughts?
Brian
Brian Foster (2):
xfs: assert that xattr inactivation never reaches a hole
xfs: buffer lru reference count error injection tag
fs/xfs/xfs_attr_inactive.c | 1 +
fs/xfs/xfs_buf.c | 16 ++++++++++++++++
fs/xfs/xfs_buf.h | 5 +----
fs/xfs/xfs_error.c | 3 +++
fs/xfs/xfs_error.h | 4 +++-
5 files changed, 24 insertions(+), 5 deletions(-)
--
2.9.5
next reply other threads:[~2017-10-10 16:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 16:47 Brian Foster [this message]
2017-10-10 16:47 ` [PATCH 1/2] xfs: assert that xattr inactivation never reaches a hole Brian Foster
2017-10-10 16:55 ` Darrick J. Wong
2017-10-10 17:09 ` Brian Foster
2017-10-12 11:27 ` [PATCH v2] xfs: fail if xattr inactivation hits " Brian Foster
2017-10-12 19:55 ` Darrick J. Wong
2017-10-10 16:47 ` [PATCH 2/2] xfs: buffer lru reference count error injection tag Brian Foster
2017-10-10 16:59 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010164756.28390-1-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.